Lubuntu: Fix GeoIP parsing
ClosedPublic
Actions

Authored by apt-ghetto on Oct 16 2020, 9:06 AM.

Details

Reviewers

wxl
tsimonq2
kc2bez

Commits

rCALASETTINGS63230172e442: Lubuntu: Fix GeoIP parsing

Summary

With the recent switch of the GeoIP service, the format has also changed from
JSON to XML. This was not correctly changed in the welcome module for Lubuntu.

Test Plan

Start Calamares (e.g. with an IP address from Europe).
Check, that the language is set correctly (e.g. French when in France).

Diff Detail

Repository

rCALASETTINGS Ubuntu Calamares Settings

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

apt-ghetto requested review of this revision.Oct 16 2020, 9:06 AM

apt-ghetto created this revision.

Harbormaster completed remote builds in B210: Diff 300.Oct 16 2020, 9:06 AM

I don't even have to test this and I know it's right since that URL only serves XML.

One thing I didn't notice before: @tsimonq2 switched from https to http which seems odd. Canonical is serving https so we should use it, IMHO. Not like that affects this particular commit, but it might be a nice addition for another one since you seem to be making a habit out of fixing what Simon broke :)

simonsfault