Page MenuHomeLubuntu Development

New upstream version.
ClosedPublic

Authored by The_LoudSpeaker on Jan 16 2021, 7:58 PM.

Details

Summary

Merge was stuck in merge-o-matic due to Diff3 conflict markers. Now resolved.

Test Plan

check if this is indeed correct merge according to ubuntu standards.

Diff Detail

Repository
rLXQTBUILDTOOLSPACKAGING lxqt-build-tools Packaging
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

The_LoudSpeaker created this revision.
kc2bez requested changes to this revision.Jan 20 2021, 1:52 AM

I have a couple of inline comments to review.

debian/changelog
1

The version number here is incorrect. It should match the Debian version since it was merged from there. TL;DR it should be 0.8.0-1ubuntu1 If this package version did not exist in Debian it would be 0.8.0-0ubuntu1. Also, the urgency should be medium not low. Take a look at this wiki page

debian/control
22

This doesn't make sense to me. ${misc:Depends}, is in the list twice. It also looks like Debian dropped ${shlibs:Depends}, It is actually noted in the changelog above ^

Here is Debian:

Depends: ${misc:Depends},
         binutils,
         cmake,
         libglib2.0-dev (>= 2.5.0),
         pkg-config,
         qttools5-dev,
         qttools5-dev-tools
Recommends: git,
            lintian
This revision now requires changes to proceed.Jan 20 2021, 1:52 AM

Fixed version number and debian/control

kc2bez requested changes to this revision.Jan 20 2021, 10:06 AM
kc2bez added inline comments.
debian/control
9

Debian is still debhelper-compat (= 12), If you change it you need to note that in the changelog.

28–29

You forgot to drop this one.

This revision now requires changes to proceed.Jan 20 2021, 10:06 AM
wxl requested changes to this revision.Jan 20 2021, 3:48 PM

A few other inlines to deal with, essentially supporting what @kc2bez already said. Hey, at least the version number is right XD

debian/control
9

I think as a general rule, we should always aim to use the latest standard versions, so let's do the upgrade.

28–29

Agreed on this. Not sure I understand why, but apparently it contradicts Architecture: all, or at least is unnecessary in light of it. Again, this is denoted in the changelog, so we should keep it.

corrected debhelper-compat version and removed $shilb:Depends

Updated. Should be fine now.

LGTM as well. Merge and upload please. Thanks for working on this!

This revision is now accepted and ready to land.Jan 23 2021, 3:35 PM