Merge was stuck in merge-o-matic due to Diff3 conflict markers. Now resolved.
Details
Details
- Reviewers
wxl kc2bez - Commits
- rLXQTBUILDTOOLSPACKAGING2e714bd11795: New upstream version.
check if this is indeed correct merge according to ubuntu standards.
Diff Detail
Diff Detail
- Repository
- rLXQTBUILDTOOLSPACKAGING lxqt-build-tools Packaging
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
I have a couple of inline comments to review.
| debian/changelog | ||
|---|---|---|
| 1 | The version number here is incorrect. It should match the Debian version since it was merged from there. TL;DR it should be 0.8.0-1ubuntu1 If this package version did not exist in Debian it would be 0.8.0-0ubuntu1. Also, the urgency should be medium not low. Take a look at this wiki page | |
| debian/control | ||
| 22 | This doesn't make sense to me. ${misc:Depends}, is in the list twice. It also looks like Debian dropped ${shlibs:Depends}, It is actually noted in the changelog above ^ Here is Debian: Depends: ${misc:Depends},
binutils,
cmake,
libglib2.0-dev (>= 2.5.0),
pkg-config,
qttools5-dev,
qttools5-dev-tools
Recommends: git,
lintian | |
Comment Actions
A few other inlines to deal with, essentially supporting what @kc2bez already said. Hey, at least the version number is right XD
| debian/control | ||
|---|---|---|
| 9 | I think as a general rule, we should always aim to use the latest standard versions, so let's do the upgrade. | |
| 28–29 | Agreed on this. Not sure I understand why, but apparently it contradicts Architecture: all, or at least is unnecessary in light of it. Again, this is denoted in the changelog, so we should keep it. | |