New upstream release of lxqt-archiver
ClosedPublic
Actions

Authored by apt-ghetto on Aug 12 2021, 9:18 AM.

Details

Reviewers

Commits

rLXQTARCHIVERPACKAGING5106535c2d0e: New upstream release of lxqt-archiver

Summary

Packaged new upstream release 0.4.0 of lxqt-archiver
Updated control, copyright, changelog and lxqt-archiver.install
Replaced upstream signing key
Fixed permissions of file debian/rules (+x)

Test Plan

Wait for D116
Build passed on https://launchpad.net/~apt-ghetto/+archive/ubuntu/ludev

Diff Detail

Repository

rLXQTARCHIVERPACKAGING lxqt-archiver Packaging

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

apt-ghetto requested review of this revision.Aug 12 2021, 9:18 AM

apt-ghetto created this revision.

Harbormaster completed remote builds in B243: Diff 347.Aug 12 2021, 9:18 AM

Please see the inline comments.

debian/control
2	I am not sure, if this line should be updated or not?
debian/copyright
6–7	I am not sure, if this line should be updated or not. In file https://github.com/lxqt/lxqt-archiver/blob/0.4.0/src/about.ui there is a copyright notice. But I think, this is not a "valid" copyright which should be considered here.

apt-ghetto mentioned this in D116: New upstream version for libfm-qt.Aug 12 2021, 1:51 PM

I left some replies to the inline comments.

debian/control
2	This could/should probably change to reflect the Lubuntu Team. When @teward added this it was valid since lxqt-archiver wasn't in our package set.
debian/copyright
6–7	I don't think it applies in this case so I think that what is here already is good.