Packaged new upstream release 0.17.1 of lxqt-powermanagement
Updated changelog, copyright, control
Renamed tag for lintian override
Details
Details
- Wait for D124
- Successfully built on https://launchpad.net/~apt-ghetto/+archive/ubuntu/ludev
Diff Detail
Diff Detail
- Repository
- rLXQTPOWERMANAGEMENTPACKAGING lxqt-powermanagement Packaging
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
| debian/control | ||
|---|---|---|
| 17 | I am not sure, why this build-dep is still needed. In my understanding, it was removed with https://github.com/lxqt/lxqt-powermanagement/commit/231759df86ec9a7097cdf2e76d2f085cb361252e | |
Comment Actions
I replied to the inline comment. I think a change in the build depends are the correct thing to do.
| debian/control | ||
|---|---|---|
| 17 | That is a good catch, I think you are correct. | |
| debian/control | ||
|---|---|---|
| 17 | If I remove libqt5x11extras5-dev and sbuild it, then it fails with: -- The C compiler identification is GNU 11.2.0
-- The CXX compiler identification is GNU 11.2.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at /usr/share/cmake-3.18/Modules/CMakeFindDependencyMacro.cmake:47 (find_package):
By not providing "FindQt5X11Extras.cmake" in CMAKE_MODULE_PATH this project
has asked CMake to find a package configuration file provided by
"Qt5X11Extras", but CMake did not find one.
Could not find a package configuration file provided by "Qt5X11Extras"
(requested version 5.12.0) with any of the following names:
Qt5X11ExtrasConfig.cmake
qt5x11extras-config.cmake
Add the installation prefix of "Qt5X11Extras" to CMAKE_PREFIX_PATH or set
"Qt5X11Extras_DIR" to a directory containing one of the above files. If
"Qt5X11Extras" provides a separate development package or SDK, be sure it
has been installed.
Call Stack (most recent call first):
/usr/share/cmake/lxqt/lxqt-config.cmake:42 (find_dependency)
CMakeLists.txt:28 (find_package)And /usr/share/cmake/lxqt/lxqt-config.cmake (liblxqt0-dev) contains find_dependency(Qt5X11Extras 5.12.0). The question is, whether it is "correct" to have this build-dep here or is there a better way to fix it? | |
Comment Actions
LGTM, I was able to get it to build locally and I can see it built in your PPA.
| debian/control | ||
|---|---|---|
| 17 | Based on that it looks like it is needed then. I don't know of a better way to fix it. | |