Page MenuHomeLubuntu

Make a path for GTK settings if it does not exist.
ClosedPublic

Authored by wxl on Sep 4 2018, 12:43 AM.

Details

Summary

Can't change GTK3 theme in lxqt-config-appearance if settings don't exist, so create it.

Test Plan
  1. Open lxqt-config-appearance
  2. Check "Set GTK themes"
  3. Change "GTK 3 Theme" to Arc
  4. Close lxqt-config-appearance
  5. Open lxqt-config-appearance

"GTK 3 Theme" should be set to Arc and not the default, Adwaita.

Diff Detail

Repository
rLXQTCONFIGPACKAGING lxqt-config Packaging
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wxl requested review of this revision.Sep 4 2018, 12:43 AM
wxl created this revision.
tsimonq2 requested changes to this revision.Sep 4 2018, 1:14 AM

You're not the actual author of the patch, please grab the one from upstream. Also, fix your UTC offset in the changelog entry (and the time, too).

This revision now requires changes to proceed.Sep 4 2018, 1:14 AM
wxl updated this revision to Diff 35.Sep 4 2018, 1:46 AM

Updated timezone and changed author on patch.

Harbormaster completed remote builds in B24: Diff 35.Sep 4 2018, 1:46 AM
wxl updated this revision to Diff 36.Sep 4 2018, 1:48 AM

Ugh, fixing timezone again.

Harbormaster completed remote builds in B25: Diff 36.Sep 4 2018, 1:48 AM
wxl added a comment.Sep 4 2018, 1:49 AM

It doesn't seem to be showing, but my changelog is updated. Sigh.

tsimonq2 accepted this revision.Sep 4 2018, 1:51 AM

LGTM, feel free to merge it.

This revision is now accepted and ready to land.Sep 4 2018, 1:51 AM
This revision was automatically updated to reflect the committed changes.
tsimonq2 changed the visibility from "All Users" to "Public (No Login Required)".Oct 2 2018, 10:06 AM