Page MenuHomeLubuntu Development
Differential D16

Changed connection editor to nm-connection-editor
ClosedPublic
Actions

Authored by hmollercl on Jul 1 2019, 2:31 PM.

Details

Reviewers
wxl
tsimonq2
Commits
rNMTRAYPACKAGING1bc4f5406954: Changed connection editor to nm-connection-editor
Summary

Changed connection editor to nm-connection-editor from network-manager-gnome

Test Plan

check if nm-tray open nm-connection-editor instead of nmtui

Diff Detail

Repository
rNMTRAYPACKAGING nm-tray Packaging
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

hmollercl requested review of this revision.Jul 1 2019, 2:31 PM
hmollercl created this revision.
Harbormaster completed remote builds in B30: Diff 43.Jul 1 2019, 2:31 PM
Harbormaster completed remote builds in B30: Diff 43.
tsimonq2 requested changes to this revision.Jul 1 2019, 3:21 PM

Fairly nitpicky, but your modifications to the patch completely change the purpose. That's fine, but you can now just modify existing information Description, Author, and Bug instead of adding your own lines. Also, please modify Bug to say Bug-Ubuntu, which follows DEP-3.

Otherwise, LGTM. Thanks!

This revision now requires changes to proceed.Jul 1 2019, 3:21 PM
hmollercl updated this revision to Diff 47.Jul 2 2019, 2:14 PM

update description of patch

Harbormaster completed remote builds in B34: Diff 47.Jul 2 2019, 2:14 PM
Harbormaster completed remote builds in B34: Diff 47.
hmollercl updated this revision to Diff 48.Jul 2 2019, 2:17 PM

updated patch bug, and authot

Harbormaster completed remote builds in B35: Diff 48.Jul 2 2019, 2:17 PM
Harbormaster completed remote builds in B35: Diff 48.
tsimonq2 requested changes to this revision.Jul 2 2019, 2:42 PM

network-manager-gnome, not network-manager-gnomer :)

Otherwise, LGTM

This revision now requires changes to proceed.Jul 2 2019, 2:42 PM
hmollercl updated this revision to Diff 50.Jul 4 2019, 12:54 AM

correct typo

Harbormaster completed remote builds in B37: Diff 50.Jul 4 2019, 12:54 AM
tsimonq2 added a comment.Jul 4 2019, 2:16 AM

LGTM.

tsimonq2 accepted this revision.Jul 4 2019, 2:16 AM
This revision is now accepted and ready to land.Jul 4 2019, 2:16 AM
wxl accepted this revision.Jul 4 2019, 7:09 PM
Closed by commit rNMTRAYPACKAGING1bc4f5406954: Changed connection editor to nm-connection-editor (authored by hmollercl, committed by wxl). · Explain WhyJul 4 2019, 7:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 51

View Options

debian/changelog

Loading...
View Options

debian/patches/generalize-terminal-for-edits.patch

Loading...
View Options

debian/patches/nm-connection-editor.patch

Loading...
View Options

debian/patches/series

Loading...