Page MenuHomeLubuntu Development
Differential D17

Edited Shortcuts.
AcceptedPublic
Actions

Authored by The_LoudSpeaker on Mon, Jul 1, 5:12 PM.

Details

Reviewers
wxl
tsimonq2
Summary
  • Shortcuts for following are modified:
    • Go to dektop
    • Send to desktop
    • Directional Cycle Windows
    • Go to Desktop Directional
    • XF86WWW
  • Shortcuts for following are removed and corresponding are added to lxqt/globalkeyshortcuts.conf
    • Toggle show desktop
    • Pcmanfm
    • Runner
    • terminal
    • task manager
  • Some commented out items are removed
    • lxpanel menu
    • lxsession default lock
    • calculator
    • screenshot
    • quit
  • Following shortcuts are completely removed
    • Ctrl+F10/11 regarding backlight
    • Ctrl+F7 xset dpms force off
    • Window tiling
Test Plan

Once this file and lxqt/globalkeyshortcuts.conf are in place,

	   Check all the specified shortcuts as per T59#1260 are working.

Diff Detail

Repository
rDEFAULTSETTINGS Lubuntu Default Settings
Branch
ubuntu/eoan
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 43
Build 43: arc lint + arc unit

Event Timeline

The_LoudSpeaker requested review of this revision.Mon, Jul 1, 5:12 PM
The_LoudSpeaker created this revision.
Harbormaster completed remote builds in B31: Diff 44.Mon, Jul 1, 5:12 PM
wxl added a comment.Mon, Jul 1, 5:22 PM

I presume there will be a corresponding differential revision for the LXQt side of things?

The_LoudSpeaker added a comment.Mon, Jul 1, 5:26 PM

Yeah. But I don't know how to go about it. Never patched a repo which is already patched. Please give instructions on the channel. :)

The_LoudSpeaker updated this revision to Diff 46.Mon, Jul 1, 6:37 PM

Edited shortcuts.
Patched rLXQTGLOBALKEYSPACKAGING. See D18.

Harbormaster completed remote builds in B33: Diff 46.Mon, Jul 1, 6:37 PM
tsimonq2 accepted this revision.Mon, Jul 1, 8:38 PM
This revision is now accepted and ready to land.Mon, Jul 1, 8:38 PM
wxl requested changes to this revision.Mon, Jul 8, 12:16 AM

As I said on D18, we should move the media keys (the XF86 ones) over to globalkeyshortcuts.conf. I understand you don't have the keys. No big deal. You can make the definitions to something else ridiculous and then hand edit the file.

This will eliminate the need for the line about Lubuntu specific bindings. It will also get around the problem that the last keybinding is outside the closing </keyboard> tag, which would ultimately be problematic.

This revision now requires changes to proceed.Mon, Jul 8, 12:16 AM
The_LoudSpeaker updated this revision to Diff 57.Tue, Jul 9, 1:01 PM

Removed media keys

Harbormaster completed remote builds in B42: Diff 57.Tue, Jul 9, 1:01 PM
wxl requested changes to this revision.Tue, Jul 9, 1:04 PM

Remove the "Lubuntu specific keybindings" line, please.

This revision now requires changes to proceed.Tue, Jul 9, 1:04 PM
The_LoudSpeaker updated this revision to Diff 58.Tue, Jul 9, 1:38 PM

Removed "Lubuntu Specific Key bindings"

Harbormaster completed remote builds in B43: Diff 58.Tue, Jul 9, 1:38 PM
wxl accepted this revision.Tue, Jul 9, 2:20 PM

Good job!

This revision is now accepted and ready to land.Tue, Jul 9, 2:20 PM
The_LoudSpeaker added a comment.Tue, Jul 9, 2:22 PM

Job is not done yet, not untill D18 gets sorted.

Revision Contents
Changeset List

Diff 58

View Options

src/etc/xdg/xdg-Lubuntu/openbox/lxqt-rc.xml

Loading...