Differential D17
Edited Shortcuts. Authored by The_LoudSpeaker on Jul 1 2019, 10:12 PM.
Details
Once this file and lxqt/globalkeyshortcuts.conf are in place, Check all the specified shortcuts as per T59#1260 are working.
Diff Detail
Event TimelineComment Actions I presume there will be a corresponding differential revision for the LXQt side of things? Comment Actions Yeah. But I don't know how to go about it. Never patched a repo which is already patched. Please give instructions on the channel. :) Comment Actions As I said on D18, we should move the media keys (the XF86 ones) over to globalkeyshortcuts.conf. I understand you don't have the keys. No big deal. You can make the definitions to something else ridiculous and then hand edit the file. This will eliminate the need for the line about Lubuntu specific bindings. It will also get around the problem that the last keybinding is outside the closing </keyboard> tag, which would ultimately be problematic. Comment Actions Modified Shortcuts
Shortcuts for following are removed
Some commented out items are removed
Following shortcuts are completely removed
Comment Actions First off, this is a native package and as the wiki describes, it should have a simple version number rather than the xubuntuy format. That said, 19.10.4. Second some quibbles:
Comment Actions Actually.. one question: on your local copy, are you on the ubuntu/eoan branch? I think I can fix it if not but that makes me worried. Comment Actions Right now I am on branch arcpatch-D17_1. Should I be on ubuntu/eoan ? something I missed? I was on ubuntu/eoan when I started. few days back, when I first filled this differential. Comment Actions Yeah you should be on ubuntu/eoan. This is why we use --nobranch with arc patch because otherwise it makes an arcpatch-Dn branch. I tried to pull down a new copy of the repo and the arc patch failed. So somehow your changes are based upon a local copy that is inconsistent with the remote copy. You might want to copy your xml file and debian/changelog, get a fresh repo, overwrite those files, and then arc diff --update D17. Comment Actions OK doing that overwrite with the changelog was a bad idea. You need to restore the changes you dropped. |