- Edited the foloowing shortcuts:
- Show Desktop
Regarding the patch, remove this:
Origin: <upstream|backport|vendor|other>, <URL, required except if Author is present> Bug: <URL to the upstream bug report if any, implies patch has been forwarded, optional> Bug-<Vendor>: <URL to the vendor bug report if any, optional> Forwarded: <URL|no|not-needed, useless if you have a Bug field, optional> Applied-Upstream: <version|URL|commit, identifies patches merged upstream, optional> Reviewed-by: <name and email of a reviewer, optional> --- This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
Your date has some extra cruft, too, and should just be:
I'd recommend adding:
Finally, I think we need to make a decision about whether or not we *are* patching this again here or whether or not we should wait for full XDG support upstream. @tsimonq2 hello???
Sorry to be particular, but we're training you, so we're going to make you do it right before we set you free to fly on your own 😄 That said, please remove this:
--- This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
path=/panel/desktopswitch2 should be path=/panel/desktopswitch
One other thing that should be added here (and should be removed from Openbox) is all the media keys (the XF86 buttons). You can just edit globalkeyshortcuts.conf.
We test to see if it works. If it does, then we will need to prioritize that first. I doubt we will get a new release, so we'll have to patch our version in Ubuntu. Once that's settled, then we deal with putting this in the right place. According to the Qt docs, barring a local config, QSettings (which is what the pull request uses) will look through XDG_CONFIG_DIRS. As our wiki implies, this should equal /etc/xdg/xdg-Lubuntu:/etc/xdg:/etc:/usr/share. rDEFAULTSETTINGS already has a /etc/xdg/xdg-Lubuntu/lxqt folder so that's where this would end up if this does work. Naturally, what we'll be putting in there is the whole file and not this patch, so things will be a bit different in final implementation.
A few problems:
- In that last change, you killed most of the changelog.
- Don't you want to use your lubuntu.me email?
- You need to update the changelog date. dch -r "" should do the trick.