Page MenuHomeLubuntu Development

Edited shortcuts so that they don't interfere with openbox key bindings.
Needs RevisionPublic

Authored by The_LoudSpeaker on Mon, Jul 1, 6:32 PM.

Details

Reviewers
wxl
tsimonq2
Summary
  • Edited the foloowing shortcuts:
    • GoToDesktop
    • Show Desktop
    • pcmanfm-qt
    • runner
    • qps
    • terminal
Test Plan

Apply this along with D17 and Check all things mentioned in T59#1260 are satisfied.

Diff Detail

Repository
rLXQTGLOBALKEYSPACKAGING lxqt-globalkeys Packaging
Branch
ubuntu/eoan
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 38
Build 38: arc lint + arc unit

Event Timeline

The_LoudSpeaker requested review of this revision.Mon, Jul 1, 6:32 PM
The_LoudSpeaker created this revision.
Harbormaster completed remote builds in B32: Diff 45.Mon, Jul 1, 6:32 PM
Harbormaster completed remote builds in B32: Diff 45.
tsimonq2 requested changes to this revision.Mon, Jul 1, 8:37 PM

Everything under debian/lxqt-globalkeys-l10n needs to be removed.

This revision now requires changes to proceed.Mon, Jul 1, 8:37 PM
wxl added a comment.Mon, Jul 1, 9:14 PM

Yeah and let's slow our roll here. We might want to see if lxqt-globalkeys doesn't actually support XDG. It should. If so, this can go in default settings after all.

wxl added a comment.Fri, Jul 5, 2:04 PM

One thing you could do while we figure this out, though, is to clean up your diff as aforementioned.

wxl added a comment.Fri, Jul 5, 4:56 PM

So I've confirmed it is hardcoded and it seems to be a known problem but it's kind of a bugaboo. @tsimonq2 maybe we should just go the route of patching globalkeys now and later when we get the patch to respect XDG, we can move that patch to default-settings?

Removed debian/lxqt-globalkeys-l10n

Harbormaster completed remote builds in B38: Diff 53.Sat, Jul 6, 4:39 PM
wxl added a comment.Sat, Jul 6, 10:13 PM

Regarding the patch, remove this:

Origin: <upstream|backport|vendor|other>, <URL, required except if Author is present>
Bug: <URL to the upstream bug report if any, implies patch has been forwarded, optional>
Bug-<Vendor>: <URL to the vendor bug report if any, optional>
Forwarded: <URL|no|not-needed, useless if you have a Bug field, optional>
Applied-Upstream: <version|URL|commit, identifies patches merged upstream, optional>
Reviewed-by: <name and email of a reviewer, optional>
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/

Your date has some extra cruft, too, and should just be:

Last-Update: 2019-07-02

I'd recommend adding:

Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/lubuntu-default-settings/+bug/1802501

Finally, I think we need to make a decision about whether or not we *are* patching this again here or whether or not we should wait for full XDG support upstream. @tsimonq2 hello???

wxl requested changes to this revision.Sat, Jul 6, 10:13 PM
This revision now requires changes to proceed.Sat, Jul 6, 10:13 PM

Added link to the bug in patch description

wxl requested changes to this revision.Sat, Jul 6, 10:42 PM

Sorry to be particular, but we're training you, so we're going to make you do it right before we set you free to fly on your own πŸ˜„ That said, please remove this:

---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
This revision now requires changes to proceed.Sat, Jul 6, 10:42 PM

updated the patch description

wxl added a comment.Sun, Jul 7, 8:07 PM
This comment was removed by wxl.
wxl requested changes to this revision.EditedSun, Jul 7, 11:48 PM

path=/panel/desktopswitch2 should be path=/panel/desktopswitch

One other thing that should be added here (and should be removed from Openbox) is all the media keys (the XF86 buttons). You can just edit globalkeyshortcuts.conf.

This revision now requires changes to proceed.Sun, Jul 7, 11:48 PM
wxl added a comment.Tue, Jul 9, 1:06 PM

Looks like there's a potential upstream pull request for making globalkeys respect XDG, so this may end up going to rDEFAULTSETTINGS after all.

So..? We wait then?

wxl added a comment.Tue, Jul 9, 2:40 PM

We test to see if it works. If it does, then we will need to prioritize that first. I doubt we will get a new release, so we'll have to patch our version in Ubuntu. Once that's settled, then we deal with putting this in the right place. According to the Qt docs, barring a local config, QSettings (which is what the pull request uses) will look through XDG_CONFIG_DIRS. As our wiki implies, this should equal /etc/xdg/xdg-Lubuntu:/etc/xdg:/etc:/usr/share. rDEFAULTSETTINGS already has a /etc/xdg/xdg-Lubuntu/lxqt folder so that's where this would end up if this does work. Naturally, what we'll be putting in there is the whole file and not this patch, so things will be a bit different in final implementation.

wxl added a comment.Sun, Jul 21, 3:17 PM

The patch got merged, so someone needs to get that in if we don't get a new release. @tsimonq2 do you know if they plan on doing an LXQt release before, say, FeatureFreeze?