Page MenuHomeLubuntu

Set default GTK theme if rc file doesn't exists.
ClosedPublic

Authored by hmollercl on Oct 4 2018, 2:51 PM.

Details

Summary

Set default GTK theme if rc file doesn't exists.

Test Plan

See if default GTK theme is according to 'gsettings get org.gnome.desktop.interface gtk-theme'

Diff Detail

Repository
rLXQTCONFIGPACKAGING lxqt-config Packaging
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

hmollercl requested review of this revision.Oct 4 2018, 2:51 PM
hmollercl created this revision.
Harbormaster completed remote builds in B58: Diff 78.Oct 4 2018, 2:51 PM

during debuild I get 12 warnings. Pastebinit of the debuild here http://paste.ubuntu.com/p/xKndSTVqnJ/

wxl requested changes to this revision.EditedOct 4 2018, 3:06 PM

You didn't delete the .pc/ directory so you need to get rid of that stuff (git rm), make a new commit, and then arc diff again.

I should point out that lintian warned you about that:

W: lxqt-config source: diff-contains-quilt-control-dir debian/.pc
This revision now requires changes to proceed.Oct 4 2018, 3:06 PM
wxl added a comment.Oct 4 2018, 3:08 PM
This comment was removed by wxl.
wxl added a comment.Oct 4 2018, 3:09 PM

Argh didn't save my inlines.

debian/patches/set-default-gtk-theme.patch
5
  1. Delete Origin.
  2. Remove ?diff=unified from the URI in Applied-Upstream.

I run the command
rm -rf !(debian) .pc/
It thought it would take cares of deleting the things not needed in arc diff.

hmollercl updated this revision to Diff 82.Oct 5 2018, 6:49 AM

deleted debian/.pc
Changes in patch header, deleted origin delted parameter diff=unified in URI

Harbormaster completed remote builds in B62: Diff 82.Oct 5 2018, 6:49 AM
tsimonq2 accepted this revision.Oct 5 2018, 9:26 AM

For some reason the diff doesn't reflect the removal of .pc/.

Otherwise, looks good to me.

This comment was removed by hmollercl.
hmollercl updated this revision to Diff 83.EditedOct 5 2018, 9:36 AM

deleting .pc files

Harbormaster completed remote builds in B63: Diff 83.Oct 5 2018, 9:36 AM
hmollercl marked an inline comment as done.Oct 5 2018, 9:38 AM
tsimonq2 accepted this revision.Oct 5 2018, 9:42 AM

Looks good to me, I'll upload later.

wxl accepted this revision.Oct 5 2018, 12:33 PM
This revision is now accepted and ready to land.Oct 5 2018, 12:33 PM
This revision was automatically updated to reflect the committed changes.