Page MenuHomeLubuntu Development

add .desktop to /usr/share/Lubuntu/applications to change icons

Authored by hmollercl on Aug 11 2019, 2:44 AM.



create /usr/share/Lubuntu/applications and added: im-config.desktop,
org.kde.skanlite.desktop, lxqt-about.desktop, pcmanfm-qt-desktop-pref.desktop,
lxqt-config-globalkeyshortcuts.desktop, system-config-printer.desktop,

Test Plan

See if files are present an we have now colorful icons in the menu for
skanlite, about-lxqt, printers, among others

Diff Detail

rDEFAULTSETTINGS Lubuntu Default Settings
No Linters Available
No Unit Test Coverage
Build Status
Buildable 57
Build 57: arc lint + arc unit

Event Timeline

hmollercl requested review of this revision.Aug 11 2019, 2:44 AM
hmollercl created this revision.

I don't know that I'm completely comfortable with this approach.

What is changing in these files, and can any of this be upstreamed?

wxl added a comment.Aug 11 2019, 5:16 PM

@tsimonq2 this is a distribution/flavor override of upstream choices for icons. We've already tried upstream. They have some hokey ideas.

@hmollercl one question I do have, though, is whether or not we can use these to override only certain keys. Could we JUST specify the Icon key and it would just override that key but otherwise use the system specification? This would be nice because this route will require us to constantly keep track of those upstream desktop entries and update ours with their changes, especially translations. I'm sure you can imagine what a maintenance pain that is going to be. Just look at the Skanlite entry.

@wxl unfortunattely the whole .desktop files is "replaced" so all the entries need to be there, and yes, we would have to track the changes.
@tsimonq2 I have only talk to papirus icon usptream they said those icons are used in some filemanager so they need to be monochrome (it doesn't pcmanfm-qt).
We could try to talk to every application and tried them to change the Icon entry in their code.
The most important to me are skanlite, system-config-printer and about-lxqt.

hmollercl added a comment.EditedAug 12 2019, 10:17 PM

in case of skanlite, the .desktop is set in the code from kde.
Should we contact them or the debian packager?
Or another option?

In case of system-config-printer, from here

wxl added a comment.Aug 13 2019, 5:20 AM


  • skanlite: kde
  • print: that's from 2015. not the right repo, apparently.

right, here it is for system-config-printer

on lxqt, tsujan says he agrees to change one of the icon, for peripherals. But for shortcuts he doesn't since it not comon (breeze doesn't have it).

wxl requested changes to this revision.Aug 17 2019, 10:39 PM

I guess until we can see what the various upstreams will do, it's a little hard to review this. Keep us updated on how that goes.

This revision now requires changes to proceed.Aug 17 2019, 10:39 PM
wxl added a comment.Aug 22 2019, 10:10 PM

@tsimonq2 looks like waiting on upstream might take a long while. Maybe we should just implement this (as individual patches) and drop patches as needed as upstream makes developments?

+1 on that approach @wxl, let's do it.

but if this is made with patches, this patches will affect all *ubuntu users.

wxl added a comment.Jan 27 2020, 5:23 PM

@hmollercl update from the various upstreams? I think at the very least we can implement the changes to LXQt applications for everyone.

Although it would be better to have the colorful icons, the e-papirus make them look in the menu. And it might be hard to maintain the .desktop in the different languages, if only we could "touch" some lines and not the whole .desktop.

wxl added a comment.Jan 27 2020, 10:38 PM

Are you suggesting we drop this?

yes, I don't think is an issue anymore with e-papirus.

wxl added a comment.Jan 28 2020, 9:16 PM

Ok, then please drop it.

hmollercl abandoned this revision.Jan 28 2020, 9:38 PM