Page MenuHomeLubuntu Development

add .desktop to /usr/share/Lubuntu/applications to change icons
Needs RevisionPublic

Authored by hmollercl on Sat, Aug 10, 9:44 PM.

Details

Reviewers
wxl
tsimonq2
Summary

create /usr/share/Lubuntu/applications and added: im-config.desktop,
org.kde.skanlite.desktop, lxqt-about.desktop, pcmanfm-qt-desktop-pref.desktop,
lxqt-config-globalkeyshortcuts.desktop, system-config-printer.desktop,
lxqt-config-input.desktop

Test Plan

See if files are present an we have now colorful icons in the menu for
skanlite, about-lxqt, printers, among others

Diff Detail

Repository
rDEFAULTSETTINGS Lubuntu Default Settings
Branch
ubuntu/eoan
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 57
Build 57: arc lint + arc unit

Event Timeline

hmollercl requested review of this revision.Sat, Aug 10, 9:44 PM
hmollercl created this revision.

I don't know that I'm completely comfortable with this approach.

What is changing in these files, and can any of this be upstreamed?

wxl added a comment.Sun, Aug 11, 12:16 PM

@tsimonq2 this is a distribution/flavor override of upstream choices for icons. We've already tried upstream. They have some hokey ideas.

@hmollercl one question I do have, though, is whether or not we can use these to override only certain keys. Could we JUST specify the Icon key and it would just override that key but otherwise use the system specification? This would be nice because this route will require us to constantly keep track of those upstream desktop entries and update ours with their changes, especially translations. I'm sure you can imagine what a maintenance pain that is going to be. Just look at the Skanlite entry.

@wxl unfortunattely the whole .desktop files is "replaced" so all the entries need to be there, and yes, we would have to track the changes.
@tsimonq2 I have only talk to papirus icon usptream they said those icons are used in some filemanager so they need to be monochrome (it doesn't pcmanfm-qt).
We could try to talk to every application and tried them to change the Icon entry in their code.
The most important to me are skanlite, system-config-printer and about-lxqt.

hmollercl added a comment.EditedMon, Aug 12, 5:17 PM

in case of skanlite, the .desktop is set in the code from kde. https://cgit.kde.org/skanlite.git/tree/src/org.kde.skanlite.desktop
Should we contact them or the debian packager?
Or another option?

In case of system-config-printer, from here https://bazaar.launchpad.net/~vcs-imports/system-config-printer/master/view/head:/system-config-printer.desktop.in

wxl added a comment.Tue, Aug 13, 12:20 AM

@hmollercl

  • skanlite: kde
  • print: that's from 2015. not the right repo, apparently.

right, here it is for system-config-printer
https://github.com/zdohnal/system-config-printer

on lxqt, tsujan says he agrees to change one of the icon, for peripherals. But for shortcuts he doesn't since it not comon (breeze doesn't have it).

wxl requested changes to this revision.Sat, Aug 17, 5:39 PM

I guess until we can see what the various upstreams will do, it's a little hard to review this. Keep us updated on how that goes.

This revision now requires changes to proceed.Sat, Aug 17, 5:39 PM