Restore the button update status matches the current state. This resolves T40 lp:#1823569
- Maniphest Tasks
- T40: Cala segfault when performing action with no selection
- rCALAPACKAGING3758f97ccd03: Restore button updates in partition page.
Verify in manual partitioning that the buttons are updated properly.
Nitpicky, but I would avoid use of Origin as it is optional when Author is present (otherwise, it's required). Additionally, It would include either the URL or the commit, with optional prefixed keywords. That said, if you were going to use it, you would actually use upstream, commit:2b149fb, which would make your Applied-Upstream a bit redundant. I've gotten into the habit of using Applied-Upstream as you can see in the packaging example. At the very least, I would pick one or the other.
Actually, one thing from me before I'm ACKing this.
Also, while you're at it, please change the commit ref to commit:2b149fb944da8d975c05d562ab55adaa9dec25bb.
Nitpick here, could you change this to Restore button updates in partition page (LP: #1823569). ?
While that current format probably matches the regex, it's not really consistent. 😄
Uh @tsimonq2 after my comment he actually used a URL instead of commit, so that one comment is irrelevant.
Also the LP bug reference does match the required regex which is why I didn't complain about it. Our own packaging guide (that you wrote) says that's all that needs to be done. If you're going to nitpick THAT much (really??) then you should change the docs.
When I get home. I got to set up a dev container I can access anywhere, but I don't have my Phab key readily available, so I can't really do that now. If you need it more urgently (might not be a bad idea so we can test and make sure it works), you might want to just do it.