Page MenuHomeLubuntu Development

added screengrab
ClosedPublic

Authored by hmollercl on Mon, Aug 12, 7:52 PM.

Diff Detail

Repository
rLUBUNTUMETAPACKAGING lubuntu-meta Packaging
Branch
ubuntu/eoan
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 60
Build 60: arc lint + arc unit

Event Timeline

hmollercl requested review of this revision.Mon, Aug 12, 7:52 PM
hmollercl created this revision.
wxl requested changes to this revision.Tue, Aug 13, 12:21 AM
wxl edited the summary of this revision. (Show Details)
wxl edited the summary of this revision. (Show Details)

Looks good except for the changelog. Seems like somehow you throttled over my last commit.

NOTE: I added the task to the description so it will autoclose as aforementioned.
This revision now requires changes to proceed.Tue, Aug 13, 12:22 AM
In D30#636, @wxl wrote:

Looks good except for the changelog. Seems like somehow you throttled over my last commit.

NOTE: I added the task to the description so it will autoclose as aforementioned.

I thought that was the way tyo proceed sinces README.md ins meta says to use dch -r.
Will fix it this night.

hmollercl updated this revision to Diff 86.Tue, Aug 13, 7:45 PM

corrected changelog

@wxl changed your previous unreleased to eoan, is it ok?

wxl accepted this revision.Tue, Aug 13, 10:42 PM

LGTM

This revision is now accepted and ready to land.Tue, Aug 13, 10:42 PM
tsimonq2 requested changes to this revision.Wed, Aug 14, 9:18 PM

@wxl please import all changes from the archive into the VCS and tag prior to landing this.

Nothing else from @hmollercl's side, thanks!

This revision now requires changes to proceed.Wed, Aug 14, 9:18 PM
wxl added a comment.Wed, Aug 14, 9:38 PM

@tsimonq2 why am I importing? We already have my last change in both places. And we tag after it hits the archive, so… ? The one thing that does need to be done is that we need tags for a lot of commits. Last was in October 2018.

The current state of the VCS does not match what's currently in the archive, when there's a slightly different changelog entry and a tag that should exist in the VCS. Please don't do this all in one commit, make importing from the archive its own commit and tag it.

This revision was not accepted when it landed; it landed in state Needs Revision.Mon, Aug 19, 10:28 PM
This revision was automatically updated to reflect the committed changes.