Page MenuHomeLubuntu Development

Changed thumbnail view icon to view-preview
ClosedPublic

Authored by hmollercl on Fri, Sep 6, 10:29 PM.

Details

Summary

Changed thumbnail view icon to view-preview, closes T117

Test Plan

open pcmanfm-qt and see thumbnail view icon

Diff Detail

Repository
rPCMANFMQTPACKAGING pcmanfm-qt Packaging
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

hmollercl requested review of this revision.Fri, Sep 6, 10:29 PM
hmollercl created this revision.
wxl requested changes to this revision.Sat, Sep 7, 9:52 AM

You need to edit the patch to be DEP3 compliant, as seen in the packaging example. Also might want to edit the description to say it "resolves T117," which can be done, I think, via the --edit switch to arc diff.

This revision now requires changes to proceed.Sat, Sep 7, 9:52 AM

this is how it looks

wxl requested changes to this revision.Sat, Sep 7, 11:11 AM
  • Please add the Last-Update field with today's date.
  • You added the T117 reference in the commit message, but not in the differential revision. When you're ready to submit changes, just do arc diff --edit and change the summary section so that it includes "resolves T117."
  • Picky (but potentially something that would render it non-compliant, depending on how smart validation tools are): add a space after the colon before the URI in Applied-Upstream.
  • Your choice: If it were me, I'd probably get rid of lines 5-7 as they're not required parts of the diff at all.
This revision now requires changes to proceed.Sat, Sep 7, 11:11 AM
hmollercl updated this revision to Diff 127.Sat, Sep 7, 11:25 AM
hmollercl edited the summary of this revision. (Show Details)

solving dep-3 and including task

hmollercl updated this revision to Diff 128.Sat, Sep 7, 11:34 AM

update changelog

hmollercl updated this revision to Diff 129.Sat, Sep 7, 11:35 AM

update changelog

wxl accepted this revision.Sat, Sep 7, 11:45 AM
This revision is now accepted and ready to land.Sat, Sep 7, 11:45 AM