Fix UnboundLocalError in automirror module
ClosedPublic
Actions

Authored by apt-ghetto on Sep 8 2019, 10:03 AM.

Details

Reviewers

wxl
tsimonq2
kc2bez

Commits

rCALASETTINGSe647964386a7: Fix UnboundLocalError in automirror module

Summary

When opening an URL, an error may be raised and the wrong, not defined variable was logged.

Test Plan

Create an HTTPError or an URLError (socket.timeout), when opening "https://ipapi.co/json"

Diff Detail

Repository

rCALASETTINGS Ubuntu Calamares Settings

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

apt-ghetto requested review of this revision.Sep 8 2019, 10:03 AM

apt-ghetto created this revision.

Harbormaster completed remote builds in B94: Diff 131.Sep 8 2019, 10:03 AM

Nice catch. To be fair, there's a lot of url and error variables thrown around that aren't the same and this makes the code really unreadable and unmaintainable. If you wanted to go ahead and fix that, using, e.g. httperror instead of error for the HTTPError exception, that would be an added plus.

This revision is now accepted and ready to land.Sep 8 2019, 5:57 PM

Thanks for picking up on this. LGTM

Closed by commit rCALASETTINGSe647964386a7: Fix UnboundLocalError in automirror module (authored by apt-ghetto, committed by wxl). · Explain WhySep 9 2019, 5:58 AM

This revision was automatically updated to reflect the committed changes.

wxl added a commit: rCALASETTINGSe647964386a7: Fix UnboundLocalError in automirror module.