Page MenuHomeLubuntu Development

Clean up automirror module
ClosedPublic

Authored by apt-ghetto on Sep 13 2019, 10:13 AM.

Details

Summary
  • Improve naming of variables
  • Add comments
Test Plan

No test plan

Diff Detail

Repository
rCALASETTINGS Ubuntu Calamares Settings
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

apt-ghetto requested review of this revision.Sep 13 2019, 10:13 AM
apt-ghetto created this revision.

Thanks for your work here! Looks good to me, it just needs some quick changelog fixes.

debian/changelog
4

This is incorrect. It should look something like this:

calamares-settings-ubuntu (1:19.10.6) eoan; urgency=medium

  * Clean up automirror module:
    - Improve naming of variables.
    - Add comments.

 -- apt-ghetto <apt-ghetto@lubuntu.me>  Fri, 13 Sep 2019 16:51:05 +0200

We do bullet points in the order of *, -, +, and then repeat (I've had to do that once).

Also, every line in the changelog entry gets a bullet point.

tsimonq2 requested changes to this revision.Sep 13 2019, 10:42 AM
This revision now requires changes to proceed.Sep 13 2019, 10:42 AM
apt-ghetto updated this revision to Diff 137.Sep 13 2019, 10:54 AM

Fix changelog entry

Use bullet points in changelog correctly.

This revision is now accepted and ready to land.Sep 13 2019, 11:09 AM
apt-ghetto marked an inline comment as done.Sep 13 2019, 11:37 AM
wxl accepted this revision.Sep 13 2019, 2:57 PM
kc2bez accepted this revision.Sep 13 2019, 3:00 PM

Thanks for adding the doc strings, it is appreciated. The variable renaming makes more sense too.

This revision was automatically updated to reflect the committed changes.