Paths

Table of Contentst

Differential D45

Added lubuntu-grub-theme
ClosedPublic
Actions

Authored by The_LoudSpeaker on Sep 18 2019, 9:04 PM.

Tags

None

Subscribers

Details

Reviewers

tsimonq2
wxl

Maniphest Tasks

T30: Theme GRUB

Commits

rARTc7b5bed2ff91: Added lubuntu-grub-theme

Summary

Custom grub theme for lubuntu. Inspired from breeze theme.

Test Plan

Test whether theme gets installed by default.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

The_LoudSpeaker requested review of this revision.Sep 18 2019, 9:04 PM

The_LoudSpeaker created this revision.

Harbormaster completed remote builds in B100: Diff 140.Sep 18 2019, 9:04 PM

The_LoudSpeaker added a task: T30: Theme GRUB.Sep 18 2019, 9:15 PM

Comments inline, otherwise LGTM.

debian/control
63	`Lubuntu`, not `lubuntu`
src/boot/grub/themes/lubuntu-grub-theme/theme.txt
1	Lubuntu
41	I'm not sure which colors these are, but check the Marketing page for more details. Bonus points if you want to move that page to the Phab wiki.

This revision now requires changes to proceed.Sep 23 2019, 1:58 PM

FYI both D45 and D47 are vying for 19.10.2, so be careful with that.

wxl mentioned this in P46 (An Untitled Masterwork).Sep 23 2019, 3:23 PM

Edited the control file.

Harbormaster completed remote builds in B109: Diff 150.Sep 24 2019, 11:11 AM

The file src/boot/grub/themes/lubuntu-grub-theme/icons/lubuntu.png has dimensions of 512x512 px.

I don't see, where this file is used. And isn't it a bit oversized, if it is used in the Grub theme?

debian/lubuntu-grub-theme.install
1	In my opinion, /etc/default/grub.d/lubuntu-theme.cfg would be the better and clearer name for the configuration file.
src/boot/grub/themes/lubuntu-grub-theme/theme.txt
6	Please remove code, that is commented out.

Updated script file name and removed some comments.

Harbormaster completed remote builds in B110: Diff 151.Sep 24 2019, 3:11 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 8 2019, 4:40 PM

Closed by commit rARTc7b5bed2ff91: Added lubuntu-grub-theme (authored by The_LoudSpeaker, committed by tsimonq2). · Explain Why

This revision was automatically updated to reflect the committed changes.

tsimonq2 added a commit: rARTc7b5bed2ff91: Added lubuntu-grub-theme.

Revision Contents
Changeset List

Path

Size

5 lines

debian/

7 lines

8 lines

22 lines

lubuntu-grub-theme.install

2 lines

lubuntu-grub-theme.postinst

24 lines

lubuntu-grub-theme.prerm

23 lines

src/

boot/

grub/

themes/

lubuntu-grub-theme/

boot_menu_c.png

boot_menu_e.png

boot_menu_n.png

boot_menu_ne.png

boot_menu_nw.png

boot_menu_s.png

boot_menu_se.png

boot_menu_sw.png

boot_menu_w.png

icons/

terminal_ne.png

terminal_nw.png

terminal_se.png

terminal_sw.png

44 lines

etc/

default/

grub.d/

lubuntu-grub-theme.cfg

1 line

Diff 156

README.md

Loading...

debian/changelog

Loading...

debian/control

Loading...

debian/copyright

Loading...

debian/lubuntu-grub-theme.install

Loading...

debian/lubuntu-grub-theme.postinst

Loading...

debian/lubuntu-grub-theme.prerm

Loading...

src/boot/grub/themes/lubuntu-grub-theme/background.png

Loading...

src/boot/grub/themes/lubuntu-grub-theme/boot_menu_c.png

Loading...

src/boot/grub/themes/lubuntu-grub-theme/boot_menu_e.png

Loading...

src/boot/grub/themes/lubuntu-grub-theme/boot_menu_n.png

Loading...

src/boot/grub/themes/lubuntu-grub-theme/boot_menu_ne.png

Loading...

src/boot/grub/themes/lubuntu-grub-theme/boot_menu_nw.png

Loading...

src/boot/grub/themes/lubuntu-grub-theme/boot_menu_s.png

Loading...

src/boot/grub/themes/lubuntu-grub-theme/boot_menu_se.png

Loading...

src/boot/grub/themes/lubuntu-grub-theme/boot_menu_sw.png

Loading...

src/boot/grub/themes/lubuntu-grub-theme/boot_menu_w.png

Loading...

src/boot/grub/themes/lubuntu-grub-theme/icons/lubuntu.png

Loading...

src/boot/grub/themes/lubuntu-grub-theme/preview.png

Loading...

src/boot/grub/themes/lubuntu-grub-theme/select_c.png

Loading...

src/boot/grub/themes/lubuntu-grub-theme/slider_c.png

Loading...

src/boot/grub/themes/lubuntu-grub-theme/slider_n.png

Loading...

src/boot/grub/themes/lubuntu-grub-theme/slider_s.png

Loading...

src/boot/grub/themes/lubuntu-grub-theme/terminal_c.png

Loading...

src/boot/grub/themes/lubuntu-grub-theme/terminal_e.png

Loading...

src/boot/grub/themes/lubuntu-grub-theme/terminal_n.png

Loading...

src/boot/grub/themes/lubuntu-grub-theme/terminal_ne.png

Loading...

src/boot/grub/themes/lubuntu-grub-theme/terminal_nw.png

Loading...

src/boot/grub/themes/lubuntu-grub-theme/terminal_s.png

Loading...

src/boot/grub/themes/lubuntu-grub-theme/terminal_se.png

Loading...

src/boot/grub/themes/lubuntu-grub-theme/terminal_sw.png

Loading...

src/boot/grub/themes/lubuntu-grub-theme/terminal_w.png

Loading...

src/boot/grub/themes/lubuntu-grub-theme/theme.txt

Loading...

src/etc/default/grub.d/lubuntu-grub-theme.cfg

Loading...