Removed shortcut for runner from globalkeys.
The runner config file added in previous commit is enough
Details
Details
- Reviewers
tsimonq2 wxl - Maniphest Tasks
- T59: fix keyboard shortcuts
- Commits
- rDEFAULTSETTINGS4b392693a650: Fixed runner's default shortcut.
Check if Meta+R opens runner by default
Diff Detail
Diff Detail
- Repository
- rDEFAULTSETTINGS Lubuntu Default Settings
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
I just want to go on record as saying that I still want our shortcuts to primarily be defined in globalkeys. We should avoid as much as possible definitions elsewhere. Something is funky with runner, either in that it is conflict with globalkeys or that runner needs to be started before globalkeys. An upstream issue will be forthcoming (please post it here for posterity @The_LoudSpeaker) to try to get to the bottom of these issues. Once that's figured out, I'd like to get the definition back in here. Hopefully we can even get rid of the runner configuration that we have (that this depends on to work, AFAIK). Until then, we need to have something that works and this will get us there and much better than some weird dpkg-divert of the Desktop Entry or a restart script, etc. Great job in working hard on figuring this out!
Comment Actions
Hey @The_LoudSpeaker I happened to be looking at this file to see what our default command for launching runner was and I almost had a heart attack thinking we didn't have one. The commentary above refreshed my memory, but it seems to me that we didn't follow up on this. I was hoping to see an upstream bug report (though this one might be appropriate for Launchpad— @hmollercl may want to confirm as the reporter) for this but I didn't find any. We should also think of a reasonable workaround assuming we won't see an upstream fix anytime soon.
Comment Actions
I only reported the issue, haven't followed up either. To be honest I don't remember much why it happens and how we solve it.
Comment Actions
@The_LoudSpeaker based on @hmollercl's comments, we should probably do three things:
- make an upstream issue
- triage the Launchpad bug accordingly
- create a task to track this, with Focal as a milestone, however hopeful it may be