Differential D60
Modified lubuntu-grub-theme Authored by The_LoudSpeaker on Nov 8 2019, 11:33 PM.
Details
Removed post and pre installation scripts and associated files. Modified installation file accordingly. This just updates the theme. After this, user will have to manually add /boot/grub/themes/lubuntu-grub-theme/theme.txt to GRUB_THEME in /etc/default/grub and then run grub-update to actually see the theme in effect. For this diff, test case is rather simple. Just install lubuntu-grub-theme and make changes to /etc/default/grub as shown in summary. Run grub-update. That's it. Important part lies after this diff lands. Now, Ideally it shouldn't. (According to grub's manual) But looking at theme from mate, I can say it will. Spoiler alert: If it does, then we have a bug in grub.
Diff Detail
Event TimelineComment Actions Isn't removing the cfg file necessarily going to render this non-functional? I was thinking just removing the prerm/postinst is all that really needed to be done, no? Also: maybe something more descriptive than "modified theme?" 😆 Comment Actions Could you please answer these questions? As far as I can see it, GRUB_THEME is used in /etc/grub.d/00_header. Comment Actions I answered in -devel. The cfg file won't be needed if "grub-install" or "grub-mkconfig" which run from cala during installation, detect the theme automatically. If they don't, I will add it again. Have it safe in my github.
This file is the one used while running "update-grub" we can't set the parameter here. Comment Actions Am I missing something here? I don't see what this is going to install other than an icon. Comment Actions Please be more verbose in your Test Case so we can confirm that the changes being made are verifiable. I'm not quite sure what's going on here from just reading your diff. Thanks for your work! |