Page MenuHomeLubuntu Development

Modified lubuntu-grub-theme
ClosedPublic

Authored by The_LoudSpeaker on Nov 8 2019, 5:33 PM.

Details

Summary

Removed post and pre installation scripts and associated files. Modified installation file accordingly.

This just updates the theme. After this, user will have to manually add /boot/grub/themes/lubuntu-grub-theme/theme.txt to GRUB_THEME in /etc/default/grub and then run grub-update to actually see the theme in effect.

Test Plan

For this diff, test case is rather simple. Just install lubuntu-grub-theme and make changes to /etc/default/grub as shown in summary. Run grub-update. That's it.

Important part lies after this diff lands.
lubuntu-grub-theme should be added to rSEED and rLUBUNTUMETAPACKAGING.
Once both of them are landed,
The new iso created should install the theme by default during installation of grub.

Now, Ideally it shouldn't. (According to grub's manual) But looking at theme from mate, I can say it will.

Spoiler alert: If it does, then we have a bug in grub.

Diff Detail

Repository
rART Artwork
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

The_LoudSpeaker requested review of this revision.Nov 8 2019, 5:33 PM
The_LoudSpeaker created this revision.

Make hummingbird visible beside the menu entry.

wxl requested changes to this revision.Nov 8 2019, 6:21 PM

Isn't removing the cfg file necessarily going to render this non-functional? I was thinking just removing the prerm/postinst is all that really needed to be done, no?

Also: maybe something more descriptive than "modified theme?" ๐Ÿ˜†

This revision now requires changes to proceed.Nov 8 2019, 6:21 PM

Modified changelog.

Nice changelog and hummingbird is linked now.

In D60#1369, @wxl wrote:

Isn't removing the cfg file necessarily going to render this non-functional? I was thinking just removing the prerm/postinst is all that really needed to be done, no?

Could you please answer these questions?

As far as I can see it, GRUB_THEME is used in /etc/grub.d/00_header.

Could you please answer these questions?

I answered in -devel. The cfg file won't be needed if "grub-install" or "grub-mkconfig" which run from cala during installation, detect the theme automatically. If they don't, I will add it again. Have it safe in my github.

As far as I can see it, GRUB_THEME is used in /etc/grub.d/00_header.

This file is the one used while running "update-grub" we can't set the parameter here.

Am I missing something here? I don't see what this is going to install other than an icon.

tsimonq2 requested changes to this revision.Fri, Nov 22, 10:01 AM

Please be more verbose in your Test Case so we can confirm that the changes being made are verifiable. I'm not quite sure what's going on here from just reading your diff.

Thanks for your work!

This revision now requires changes to proceed.Fri, Nov 22, 10:01 AM
The_LoudSpeaker edited the summary of this revision. (Show Details)Fri, Nov 22, 12:46 PM
The_LoudSpeaker edited the test plan for this revision. (Show Details)

Someone GTM Thanks!

kc2bez accepted this revision.Sat, Dec 7, 6:44 AM

This portion looks ok to me but I would really like @tsimonq2 and @wxl to weigh in.

This revision was not accepted when it landed; it landed in state Needs Revision.Mon, Dec 9, 6:04 PM
Closed by commit rART94efe49d6835: Modified lubuntu-grub-theme (authored by The_LoudSpeaker, committed by kc2bez). ยท Explain Why
This revision was automatically updated to reflect the committed changes.