Page MenuHomeLubuntu Development
Differential D65

Clean up code
ClosedPublic
Actions

Authored by apt-ghetto on Dec 8 2019, 4:30 PM.

Details

Reviewers
tsimonq2
Commits
rCI04ea168cff05: Clean up code
Summary
  • Remove unused import
  • Remove unused variables
  • Empty string is always False, don't check it twice
  • Use os.path.join to create a path
Test Plan

Check that the behaviour is the same as before.

Diff Detail

Repository
rCI CI Tooling
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

apt-ghetto requested review of this revision.Dec 8 2019, 4:30 PM
apt-ghetto created this revision.
Harbormaster completed remote builds in B143: Diff 197.Dec 8 2019, 4:30 PM
tsimonq2 accepted this revision.Feb 24 2020, 7:48 PM

Thanks! Sorry for the delay on this.

This revision is now accepted and ready to land.Feb 24 2020, 7:48 PM
Closed by commit rCI04ea168cff05: Clean up code (authored by apt-ghetto, committed by tsimonq2). · Explain WhyApr 23 2020, 9:43 AM
This revision was automatically updated to reflect the committed changes.
tsimonq2 added a commit: rCI04ea168cff05: Clean up code.

Revision Contents
Changeset List

PathSize
ci/
30 lines

Diff 272

View Options

ci/jobgenerator.py

Loading...