Added SAL_USE_VCLPLUGIN=qt5 env var in session.conf so libreoffice use qt5 VCL
ClosedPublic
Actions

Authored by hmollercl on Jan 26 2020, 1:50 AM.

Details

Reviewers

wxl
tsimonq2
kc2bez

Commits

rDEFAULTSETTINGS2812e609faf1: Added SAL_USE_VCLPLUGIN=qt5 env var in session.conf so libreoffice use qt5 VCL

Summary

Added SAL_USE_VCLPLUGIN=qt5 enviroment variable in session.conf xdg so libreoffice use qt5 vcl plugin

See T146 for context.

Test Plan

run env in terminal and se the value of SAL_USE_VCLPLUGIN

Diff Detail

Repository

rDEFAULTSETTINGS Lubuntu Default Settings

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

hmollercl requested review of this revision.Jan 26 2020, 1:50 AM

hmollercl created this revision.

Harbormaster completed remote builds in B155: Diff 214.Jan 26 2020, 1:50 AM

I presume you wanted reviewers here? :)

hmollercl added reviewers: wxl, tsimonq2, kc2bez.Jan 27 2020, 1:01 AM

wxl accepted this revision.Jan 27 2020, 1:47 AM

This revision is now accepted and ready to land.Jan 27 2020, 1:47 AM

mmmm, maybe we should revert this, there is a bug when exporting to pdf using embeded fonts see https://bugs.documentfoundation.org/show_bug.cgi?id=125234

Is there any other way to make this work? Or hope that upstream will fix it?

In D72#1617, @wxl wrote:

Is there any other way to make this work? Or hope that upstream will fix it?

apparently we will have to wait upstream. We could let the envvar but not the package, the package an not the envvar or none, but with both vcl=qt5 will be used and the problem in generating pdf will happen.

@hmollercl based on your comments we're holding up on this one right?

@kc2bez as i said with the other fix, I think we should just keep rolling with this and test it hard. It doesn't hurt to have it a little broken in the development release, contrary to what folks may imagine XD

Ok @wxl , sounds good. I will let you upload this one though ;)

Aw you're no fun @kc2bez XD

Closed by commit rDEFAULTSETTINGS2812e609faf1: Added SAL_USE_VCLPLUGIN=qt5 env var in session.conf so libreoffice use qt5 VCL (authored by hmollercl, committed by wxl). · Explain WhyFeb 1 2020, 7:34 PM

This revision was automatically updated to reflect the committed changes.

wxl added a commit: rDEFAULTSETTINGS2812e609faf1: Added SAL_USE_VCLPLUGIN=qt5 env var in session.conf so libreoffice use qt5 VCL.