Add Jenkins nagging to Lugito
ClosedPublic
Actions

Authored by tsimonq2 on Apr 23 2020, 2:08 PM.

Details

Reviewers

wxl
teward
apt-ghetto

Commits

rLUGITO9b4358ed984e: Add Jenkins nagging to Lugito

Test Plan

Deploy I guess?

Diff Detail

Repository

rLUGITO Lugito

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tsimonq2 requested review of this revision.Apr 23 2020, 2:08 PM

tsimonq2 created this revision.

A unit test for jenkins.py would be very nice with some fake data.

I have two failing tests with pytest. Is this Python3 or Python2?

lugito/connectors/jenkins.py
120	undefined variable job_name
lugito/webhooks.py
193	Overwrites the function of line 169 jenkinsprojectstatus() or write_jenkins_project_status_to_irc() might be better than a generic name like jenkinstrigger()

This revision now requires changes to proceed.Apr 23 2020, 7:48 PM

Address @apt-ghetto's inline comments.

Harbormaster completed remote builds in B198: Diff 276.Apr 23 2020, 11:23 PM

Could you look at this again, @apt-ghetto?

I addressed your inline comments. As for tests, this all should be Python 3.

I did notice a lot of the source could probably be cleaned out because of that, but I simply haven't quite had the motivation (yet). For now, I'd say that's a separate thing.

Looks good to me.

This revision is now accepted and ready to land.Apr 25 2020, 3:12 PM

teward accepted this revision.May 26 2020, 3:55 PM

Closed by commit rLUGITO9b4358ed984e: Add Jenkins nagging to Lugito (authored by tsimonq2). · Explain WhyMay 26 2020, 6:17 PM

This revision was automatically updated to reflect the committed changes.

tsimonq2 added a commit: rLUGITO9b4358ed984e: Add Jenkins nagging to Lugito.