Deploy I guess?
Details
Details
Diff Detail
Diff Detail
- Repository
- rLUGITO Lugito
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
A unit test for jenkins.py would be very nice with some fake data.
I have two failing tests with pytest. Is this Python3 or Python2?
lugito/connectors/jenkins.py | ||
---|---|---|
120 | undefined variable job_name | |
lugito/webhooks.py | ||
193 | Overwrites the function of line 169 jenkinsprojectstatus() or write_jenkins_project_status_to_irc() might be better than a generic name like jenkinstrigger() |
Comment Actions
Could you look at this again, @apt-ghetto?
I addressed your inline comments. As for tests, this all should be Python 3.
I did notice a lot of the source could probably be cleaned out because of that, but I simply haven't quite had the motivation (yet). For now, I'd say that's a separate thing.