Page MenuHomeLubuntu Development
Differential D98

Set GRUB_THEME parameter
AbandonedPublic
Actions

Authored by The_LoudSpeaker on Jul 18 2020, 7:27 PM.

Details

Reviewers
wxl
tsimonq2
kc2bez
Summary

This revison sets GRUB_THEME parameter to lubuntu-grub-theme/theme.txt present inder /usr/share/grub/themes/

Test Plan

Check if GRUB_THEME gets set automatically after installation

Diff Detail

Repository
rCALASETTINGS Ubuntu Calamares Settings
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 208
Build 208: arc lint + arc unit

Event Timeline

The_LoudSpeaker requested review of this revision.Jul 18 2020, 7:27 PM
The_LoudSpeaker created this revision.
Harbormaster completed remote builds in B206: Diff 295.Jul 18 2020, 7:27 PM
tsimonq2 requested changes to this revision.Jul 18 2020, 10:16 PM

Make sure that lubuntu-grub-theme is directly depended on by the Lubuntu settings please.

This revision now requires changes to proceed.Jul 18 2020, 10:16 PM
kc2bez requested changes to this revision.Jul 19 2020, 3:48 AM
kc2bez added inline comments.
debian/changelog
6

Might want to take a look at your email too.

The_LoudSpeaker updated this revision to Diff 296.Jul 20 2020, 4:40 PM

Added lubuntu-grub-theme as depends for calamares-settings-lubuntu

Harbormaster completed remote builds in B207: Diff 296.Jul 20 2020, 4:40 PM
The_LoudSpeaker updated this revision to Diff 297.Jul 20 2020, 4:42 PM

Update email address

Harbormaster completed remote builds in B208: Diff 297.Jul 20 2020, 4:42 PM
kc2bez requested changes to this revision.Jul 25 2020, 6:35 PM

I tested this by editing this in a live session and it doesn't seem to have the desired result.


Also the live iso has the same black grub screen now and the language selection is not present.

This revision now requires changes to proceed.Jul 25 2020, 6:35 PM
kc2bez added a comment.Dec 1 2020, 11:48 AM

Raman, I think this one can be abandon too since grub does the right thing and doesn't require any Calamares changes.

The_LoudSpeaker abandoned this revision.Dec 3 2020, 11:09 AM
The_LoudSpeaker marked an inline comment as done.

Revision Contents
Changeset List

PathSize
debian/
7 lines
1 line
lubuntu/
modules/
1 line

Diff 297

View Options

debian/changelog

Loading...
View Options

debian/control

Loading...
View Options

lubuntu/modules/grubcfg.conf

Loading...