Page MenuHomeLubuntu Development

(An Untitled Masterwork)
ActivePublic

Authored by kc2bez on Fri, Sep 20, 7:37 PM.
Failed to upload binary "1910-Boat-on-beach-wallpaper.png".Failed to upload binary "1910-Caribbean-sunset-wallpaper.png".Failed to upload binary "1910-Lubuntu-default-wallpaper.png".Failed to upload binary "1910-Lubuntu-eoan-ermine.png".Failed to upload binary "1910-Lubuntu-logo.png".

Event Timeline

kc2bez created this paste.Fri, Sep 20, 7:37 PM

I got this when I did an arc diff for D47

apt-ghetto added a subscriber: apt-ghetto.EditedSat, Sep 21, 2:59 AM

What is the file size?

Found it: 10, 5, 1, 2, and 10 MB

There might be some file size restriction in the git config and/or phab config.

I checked out your revision with arc patch D47 --nobranch and the 1910* files have a file size of 0 bytes.

Here is a ls of the folder.

-rw-rw-r-- 1 ds ds 2.3M Sep 20 17:32 1804-lubuntu-default-wallpaper-h.png
-rw-rw-r-- 1 ds ds 2.0M Sep 20 17:32 1804-lubuntu-default-wallpaper.png
-rw------- 1 ds ds  11M Sep 20 16:51 1910-Boat-on-beach-wallpaper.png
-rw------- 1 ds ds 5.5M Sep 20 17:13 1910-Caribbean-sunset-wallpaper.png
-rw------- 1 ds ds 1.7M Sep 20 16:38 1910-Lubuntu-default-wallpaper.png
-rw------- 1 ds ds 2.1M Sep 20 17:04 1910-Lubuntu-eoan-ermine.png
-rw------- 1 ds ds  11M Sep 20 16:50 1910-Lubuntu-logo.png
lrwxrwxrwx 1 ds ds   34 Sep 20 17:46 lubuntu-default-wallpaper.png -> 1910-Lubuntu-default-wallpaper.png

I wondered about the file size restrictions too but there are two of them that are the same size as the existing wallpapers.

Looking at the above, I wonder if it isn't a permissions issue...

I changed the permissions and got the same result.

-rw-rw-r-- 1 ds ds 2.3M Sep 20 17:32 1804-lubuntu-default-wallpaper-h.png
-rw-rw-r-- 1 ds ds 2.0M Sep 20 17:32 1804-lubuntu-default-wallpaper.png
-rw-rw-r-- 1 ds ds  11M Sep 20 16:51 1910-Boat-on-beach-wallpaper.png
-rw-rw-r-- 1 ds ds 5.5M Sep 20 17:13 1910-Caribbean-sunset-wallpaper.png
-rw-rw-r-- 1 ds ds 1.7M Sep 20 16:38 1910-Lubuntu-default-wallpaper.png
-rw-rw-r-- 1 ds ds 2.1M Sep 20 17:04 1910-Lubuntu-eoan-ermine.png
-rw-rw-r-- 1 ds ds  11M Sep 20 16:50 1910-Lubuntu-logo.png
lrwxrwxrwx 1 ds ds   34 Sep 20 17:46 lubuntu-default-wallpaper.png -> 1910-Lubuntu-default-wallpaper.png
Linting...
No lint engine configured for this project.
Running unit tests...
No unit test engine is configured for this project.
Uploading chunks (3 chunks to upload).
Uploading chunks (3 chunks to upload).                                        
Failed to upload binary "1910-Boat-on-beach-wallpaper.png".Failed to upload binary "1910-Caribbean-sunset-wallpaper.png".Failed to upload binary "1910-Lubuntu-default-wallpaper.png".Failed to upload binary "1910-Lubuntu-eoan-ermine.png".Failed to upload binary "1910-Lubuntu-logo.png".

    Continue? [Y/n] y

Upload complete.
 SKIP STAGING  No staging area is configured for this repository.
Updated an existing Differential revision:
        Revision URI: https://phab.lubuntu.me/D47

Included changes:
  M       debian/changelog
  M       debian/lubuntu-artwork.install
  A (img) src/usr/share/lubuntu/wallpapers/1910-Boat-on-beach-wallpaper.png
  A (img) src/usr/share/lubuntu/wallpapers/1910-Caribbean-sunset-wallpaper.png
  A (img) src/usr/share/lubuntu/wallpapers/1910-Lubuntu-default-wallpaper.png
  A (img) src/usr/share/lubuntu/wallpapers/1910-Lubuntu-eoan-ermine.png
  A (img) src/usr/share/lubuntu/wallpapers/1910-Lubuntu-logo.png
  M       src/usr/share/lubuntu/wallpapers/lubuntu-default-wallpaper.png
wxl added a subscriber: wxl.Mon, Sep 23, 10:23 AM

Just to add some stuff I found:

  1. The "Failed to upload binary" error comes from the Arcanist code. This suggests it's not a git issue.
  2. There's no file size limit on rART.
  3. In the GUI, it shows a file size for each of the files.
  4. The raw diff seems to be invalid for the binaries. Compare to D45 or D20 which also has binaries.
  5. Changing the database limit (storage.mysql-engine.max-size) doesn't help.
  6. There is no other relevant limit that I can find in any of the settings for Phabricator in general.
  7. There's naturally HTTP and PHP upload limits but I'm not sure those are relevant. Default is 1MB for nginx and 2MB for PHP, though, FWIW.

Since we have seen other <1MB files uploaded by other folks, perhaps it would be interesting to see if you have any problem with that.

tsimonq2 changed the visibility from "All Users" to "Public (No Login Required)".Mon, Sep 23, 10:27 AM
tsimonq2 added a subscriber: kc2bez.
tsimonq2 added a subscriber: tsimonq2.

I say we just push the commit directly to the Git repository and audit the commit once it's pushed. I trust Dan enough to know that he knows what he's doing.

If you want to hunt down the Arc bug, by all means, but we need to move forward.

wxl added a comment.Mon, Sep 23, 10:34 AM

Fair enough, but testing one little file should be fairly easy. If the issue is actually on Dan's side, pushing directly probably won't work, either. At least at that point we know where to look.

This really needs to be done by the end of the day so we can get it in on time; I don't mean to be a pain but we need to move forward here.

Thanks for your work.

wxl added a comment.Mon, Sep 23, 5:49 PM

Just tried to upload it through arc myself and got the same error.

wxl added a comment.Mon, Sep 23, 6:30 PM

There is a limit on blob (read: MySQL) storage that is additionally limited by MySQL itself (see max_allowed_packet) but supposedly if we have another storage set up it should fall back to that and we have S3 set up to handle up to 8MB.

wxl added a comment.Mon, Sep 23, 6:31 PM

On the other hand, it looks like it is related to the webserver settings.