Page MenuHomeLubuntu Development
Create Task
Maniphest T175

GeoIP service in automirror module
Open, LowPublic
Actions

Description

The GeoIP service was changed from ipapi.co/json to geoip.ubuntu.com/lookup in version 20.10 Groovy Gorilla.

The automirror module is a downstream module, which is still using the ipapi.co url and JSON parsing.

Todo:

  • The imported Python module logging does not log to the Calamares session.log file. Replace it with the logging functionality from libcalamares.utils.
  • It is not a good idea to use two different urls to do the lookup with two different parsing methods. Ideally, there is only one lookup and all the modules can use the result of this single lookup. This requires some upstream changes to consolidate the GeoIP lookup. Known modules which use GeoIP:
    • automirror
    • locale
    • welcome

Related Objects
Search...

StatusAssignedTask
 OpenNoneT213 Lubuntu 22.10
 OpenNoneT175 GeoIP service in automirror module

Event Timeline

apt-ghetto created this task.Oct 16 2020, 9:27 AM
apt-ghetto added a parent task: T157: Unassigned tasks or without scope.
wxl edited parent tasks, added: T172: Lubuntu 21.04; removed: T157: Unassigned tasks or without scope.Jan 6 2021, 10:41 PM
apt-ghetto removed apt-ghetto as the assignee of this task.Jan 9 2021, 5:11 PM

I don't have the time at the moment to work on this task.

wxl added a subscriber: wxl.Jan 10 2021, 6:29 PM

No problem. It should be a trivial thing to resolve. Thanks so much for bringing it up!

wxl added a comment.Feb 22 2021, 6:45 PM

I'm gonna pass on the consolidation. Given the modular nature of Calamares and the fact that not everyone is going to use every module AND the fact that automirror is solely ours, I don't think that it's going to be quite easy to implement a one time lookup sort of thing.

Using geoip.ubuntu.com everywhere in the rCALASETTINGS instead of ipapi.co (and xml instead of json) should be trivial, though.

As for the logging, that shouldn't be too hard though fatal errors should be passed through.

wxl added a comment.Feb 22 2021, 9:11 PM

Well, trivial, but not THAT trivial. It should be pointed out automirror is using a json parser, so we need an xml one. Looking at the docs and the vulnerabilities in XML, I'm inclined to use defusedxml.

wxl triaged this task as Low priority.Feb 26 2021, 5:24 PM
kc2bez edited parent tasks, added: T204: Lubuntu 21.10; removed: T172: Lubuntu 21.04.Apr 13 2021, 11:42 AM
kc2bez added a subscriber: kc2bez.

Moving this to 21.10

svinoba added a subscriber: svinoba.May 9 2021, 5:26 PM
kc2bez edited parent tasks, added: T211: Lubuntu 22.04; removed: T204: Lubuntu 21.10.Oct 10 2021, 7:49 PM

This would be excellent to have for 22.04

kc2bez edited parent tasks, added: T213: Lubuntu 22.10; removed: T211: Lubuntu 22.04.Mar 27 2022, 1:48 PM

We need to tackle this one in 22.10