Page MenuHomeLubuntu Development

Transfer testcases to the actual testcase branch
Open, NormalPublic

Description

We're the only flavor to use Calamares, therefore, we have some extra testing overhead compared to other flavors. Up to now, this has lived in Testing Checklist, but it really should be transferred to the ISO QA tracker. Instructions on doing that can be found here; once they're written and proposed for merging, I can merge them and complete the correct administration tasks.

Event Timeline

tsimonq2 triaged this task as Normal priority.Apr 13 2019, 12:37 PM
tsimonq2 created this task.
tsimonq2 added a parent task: T41: Lubuntu 19.10.
guiverc claimed this task.Jul 26 2019, 6:47 AM

Hey @guiverc, any progress on this one?

guiverc added a comment.EditedSat, Aug 3, 12:48 AM

I ran the installer a few times & made notes (largely a comparison between 19.10's install and the manual), right now I have no idea where those notes are (pad.ubuntu.com as I recall, but i'll have to find the email or whatever breadcrumb I left for myself to locate it). I also downloaded existing testcases and then looked at alternate editors as I felt my usual editor would be error prone (I didn't like how it appeared).

My intention was to continue on it today, but i've been doing 18.04.3 instead...

https://pad.ubuntu.com/l9zgyhdZab (*minimal there except one image different to manual example*)

Our current (testcase 1701) is written for "Erase Disk" however it doesn't always show.

On a (vbox) VM on this (d980) box it shows between Replace.a.partition and Manual.partitioning. I got the same on another vbox session (hp 8200), or test on where I had two recent 18.04.3 installs (install & a install(auto-resize)) and Erase disk appears, as it did on my d780 (multiple ubuntu installs).

However on the machine besides (d755) me the current daily offers only, likewise another d755 (which contains only a single debian-testing installation) :-

  • Install.alongside
  • Replace a partition
  • Manual partitioning

Should I/we write text under the "Erase Disk" to allow for that situation (if so what?; it'll get complicated fast..) or leave it blank as it currently is letting the tester work around the problem in making the test work...

Is it because of a mounted partition? I looked and didn't see one, rebooted d755 & mount |grep sd shows only the install-media mounted...

wxl added a subscriber: wxl.Tue, Aug 13, 12:08 AM

Weird. Let's see the ~/.cache/Calamares/session.log on that one.

https://paste.ubuntu.com/p/Cvvx77Gv5r/
has the ~/.cache/Calamares/session.log file.
I hadn't exited the installer at that stage, it was grabbed when it was at the

  • install alongside
  • replace partition
  • manual partitioning

question, ie. no erase disk & install option provided. Single 80gb disk; partitions for /, swap & /home only

kc2bez added a subscriber: kc2bez.Tue, Aug 13, 12:54 PM
In T56#1982, @guiverc wrote:

https://paste.ubuntu.com/p/Cvvx77Gv5r/
has the ~/.cache/Calamares/session.log file.
I hadn't exited the installer at that stage, it was grabbed when it was at the

  • install alongside
  • replace partition
  • manual partitioning

question, ie. no erase disk & install option provided. Single 80gb disk; partitions for /, swap & /home only

I am guessing that the Swap is mounted as /dev/sda2?

2019-08-13 - 05:38:37 [6]: Checking if "/dev/sda2" can be resized. 
2019-08-13 - 05:38:37 [6]:  ..  NO, partition is mounted 
2019-08-13 - 05:38:37 [6]: Checking if "/dev/sda2" can be replaced. 
2019-08-13 - 05:38:37 [6]:  ..  NO, it is mounted.

:) I didn't think of swap, and that would apply to all systems I tested on.
and easy to deal with in a text line; I'm thinking we ask testers to leave a comment on that one

wxl added a comment.Tue, Aug 13, 11:08 PM

Here's what I know (and this is covered in the manual, but feel free to suggest improvements; it might be good to have GUI instructions, especially as it relates to any mounted partition rather than just swaps):

  • If a device has any partitions mounted, you will not get the Erase Disk option
  • Swaps are automounted by the core Ubuntu system in live, for better or for worse
  • It is beneficial to have swaps mounted on the live system, at least for systems low on memory, so we don't want to make some sort of universal change where we necessarily
  • There's been plenty of discussion upstream about posting a warning or providing an option to unmount things but no real traction on doing anything about it
  • I don't have the hardware to test but I have reason to believe based on some support items and bugs I've seen that eMMC devices are automounted

Therefore, I believe the testcase should provide instructions to:

  • Check to see if the target drive has any mounted partitions
  • Unmount any partitions if found

…before launching the installer.

Thanks Walter & Dan too.

I'm disappointed I didn't think of swap (and yeah I did know the kernel mounts it if detected but it still escaped me).

I'll add messages re: your instructions when I get a chance. At least 3 of the diffs were added to https://pad.ubuntu.com/l9zgyhdZab though I've only made the (4) BIOS cases so far (2x4 uefi still to go). I've compared each to an install so i believe they're accurate (though I've yet to read the diffs to look for language/typos..)

wxl added a comment.Wed, Aug 14, 9:08 PM

@guiverc looking good. I would suggest simply committing these as new test cases (we need to keep the old ones for 18.04 for now) as long as you have a complete test case. We can worry about proofreading and more minor edits later.

BTW remember we have notes.lubuntu.me for collaborative documentation. If you need a login, let me or @tsimonq2 know.

They will be new testcases; the files currently are all local (diffs online were a form of backup, though created at that point as I wanted two to speed creation of the fourth one via copy/paste); I haven't yet done the vm install to verify fourth is good. I don't yet understand the upload steps which is why they're all local - but I'll/we'll get there.

Thanks re: notes.lubuntu.me, a copy exists there too but I didn't click 'publish' in case it was publish to world (https://notes.lubuntu.me/3mjA6fgTS56sKUd1dW516g?edit) though it'll be identical to pad.ubuntu.com link I suspect; I aim to continue on this today (arvo/later)

wxl added a comment.Wed, Aug 14, 9:46 PM

Sign ups to notes are closed, so if it's public, it doesn't matter ☺

I just booted [19.10] daily on vaiocrap & noticed an OEM option at grub; maybe we should have testcase(s) for that??
(i'm starting EFI set)

In T56#2000, @wxl wrote:

...

Therefore, I believe the testcase should provide instructions to:

  • Check to see if the target drive has any mounted partitions
  • Unmount any partitions if found

…before launching the installer.

I was going to handle it with a

<dd>If "Erase disk" does not show you have a mounted partition, please close installer, umount your partitions (it may be a swap partition that was mounted on boot) and return to the 'click the "Install FAMILY XX.YY" icon step'</dd>

@wxl Is this acceptable? (my first draft had a scream aloud that was just replaced by that message)

My Reasoning: On a lot of boots I've recently done, I did not have the trouble. Thus why have testers check for 'mount' if the lack of "Erase disk" will tell them.. They can then exit, umount & return a few steps... [yeah it's a "GOTO" - but I'm an ex-COBOL dev :) ]

I don't believe anything shows any differently for secure+EFI boot, (vs efi) so it'll use identical testcases as EFI.

The EFI ones differ slightly [to bios] ..

guiverc@d960-ubu2:/de2900/lubuntu/qa-testing/1910-image-tests$ diff full_disk_install_encypt_bios_noweb.txt full_disk_install_encypt_efi_noweb.txt
23c23

< <dd>Please ensure you see BIOS listed besides your drive. If you see EFI it's covered in another testcase</dd>

<dd>Please ensure you see EFI listed besides your drive. If you see BIOS it's covered in another testcase</dd>

I've updated the notes diffs (https://notes.lubuntu.me/3mjA6fgTS56sKUd1dW516g) but not pad.ubuntu.com

Files pass format checks..
guiverc@d960-ubu2:/de2900/lubuntu/qa-testing/1910-image-tests$ test-case-format full_disk_install_*.txt
full_disk_install_encypt_bios_noweb.txt
full_disk_install_encypt_bios_waitweb.txt
full_disk_install_encypt_efi_noweb.txt
full_disk_install_encypt_efi_waitweb.txt
full_disk_install_noencypt_bios_noweb.txt
full_disk_install_noencypt_bios_waitweb.txt
full_disk_install_noencypt_efi_noweb.txt
full_disk_install_noencypt_uefi_waitweb.txt

wxl added a comment.Thu, Aug 15, 2:19 PM

I'd suggest this:

<dd>If "Erase disk" does not show, your target device has a mounted partition. Please close installer, umount your partitions (most likely a swap partition that was mounted on boot), and return to the 'click the "Install FAMILY XX.YY" icon step'</dd>

Slight difference, but it should make things more clear. Should we give specific instructions to unmount?