Page MenuHomeLubuntu

Our default LibreOffice theme looks bad
Open, HighPublic

Description

It looks bad, yo.

Related Objects

Event Timeline

tsimonq2 created this task.Sat, Oct 6, 7:58 PM
tsimonq2 triaged this task as High priority.

I installed these two packages and the default changed to Breeze, where Breeze is the default GTK widget style.

apt install libreoffice-gtk3 libreoffice-style-breeze

tsimonq2 claimed this task.Sun, Oct 7, 5:29 PM

You're right.

tsimonq2 reopened this task as Open.Tue, Oct 9, 1:46 PM

It still looks bad with those packages installed on a fresh live ISO:

hmollercl added a subscriber: hmollercl.EditedTue, Oct 9, 8:34 PM

I've had problemas creating the patch.
git checkout ubuntu/cosmic doesn't work and there is also no debian changelog. Any way, the diff is this:

Description: Set default libreoffice icons to breeze for lxqt
Author: Hans P. Möller <hmoller@gmail.com>
Last-Update: 2018-10-09
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
--- a/debian/vcl/source/app/IconThemeSelector.cxx
+++ b/debian/vcl/source/app/IconThemeSelector.cxx
@@ -57,7 +57,8 @@ IconThemeSelector::GetIconThemeForDeskto
     (void)desktopEnvironment;
 #else
     if ( desktopEnvironment.equalsIgnoreAsciiCase("kde4") ||
-         desktopEnvironment.equalsIgnoreAsciiCase("kde5") ) {
+         desktopEnvironment.equalsIgnoreAsciiCase("kde5") ||
+         desktopEnvironment.equalsIgnoreAsciiCase("lxqt") ) {
         r = "breeze";
     } else
     if ( desktopEnvironment.equalsIgnoreAsciiCase("macosx") ) {
wxl added a comment.Wed, Oct 10, 12:12 AM

@hmollercl are you sure that's sufficient?

wxl added a comment.Wed, Oct 10, 12:15 AM

Nevermind. Looking at the example you gave that GNOME used, I think it's clear it's sufficient because the rest of the patch is a test.

hmollercl added a comment.EditedWed, Oct 10, 12:46 AM

so, what should I do now? Trying to test build gave me:

hmoller@hmoller-pc:~/LOPatch/debian$ debuild -d --no-sign
debuild: found debian/changelog for package libreoffice in the directory
  /home/hmoller/LOPatch
but this directory name does not match the package name according to the
regex  PACKAGE(-.+)?.

To run debuild on this package, see the --check-dirname-level and
--check-dirname-regex options; run debuild --help for more info.
wxl added a comment.Wed, Oct 10, 12:57 AM

Nothing. Building as we speak.

Trying to test build gave me:

hmoller@hmoller-pc:~/LOPatch/debian$ debuild -d --no-sign
debuild: found debian/changelog for package libreoffice in the directory
  /home/hmoller/LOPatch
but this directory name does not match the package name according to the
regex  PACKAGE(-.+)?.

To run debuild on this package, see the --check-dirname-level and
--check-dirname-regex options; run debuild --help for more info.
wxl added a comment.Wed, Oct 10, 1:05 AM

Yeah well I just got that far, too, and it's all sorts of screwed up. I'm just going to go ahead and submit it. BTW, I put your name on it.

I'm doing some lobbying to get this in last minute but it also needs to be tested to make sure we're not barking up the wrong tree here.

Something just doesn't seem right here, and it reminds me of the XDG fun we had to go through with SDDM.

I just did chat with oSoMoN on IRC, and this is nowhere near what we actually need to get this working.

He's (understandably) not comfortable patching in our packaging and would rather see some upstream review and acceptance before pulling it in as a distro patch.

We could squeeze it in last minute, but that all depends on LibreOffice upstream. There's no guarantees here.

I'll grab this one for the sake of "I'm knees deep in it thus far", heh.

wxl added a comment.Wed, Oct 10, 9:58 AM

To be clear, the problem is that the patch would work, but the upstream code doesn't allow LXQt as a valid value for desktopEnvironment. The appropriate places to fix are denoted by oSoMoN.

Sure.

I'll take care of it.

Submitted upstream.

Let's hope for a prompt review. If not, we can either SRU or just wait for next cycle.

There is a comment upstream saying that it won't work "because the value of $DESKTOP_SESSION is "Lubuntu", not "lxqt"." I think they are thinking in 18.04.

$ echo $DESKTOP_SESSION
Lubuntu

No, unfortunately they are correct.

After talking with oSoMoN, the only thing we can do at this point is prepare a 0-day SRU.

Can someone please file a Launchpad bug and fill it out with the SRU template?

wxl added a comment.Thu, Oct 11, 2:45 PM

On the other hand $XDG_CURRENT_DESKTOP is LXQt. I'm not sure why they're looking to $DESKTOP_SESSION instead.

wxl added a comment.Thu, Oct 11, 4:29 PM

Given the above, @tsimonq2 I don't think any one of us can fill out the SRU template. We need more clarity on what exactly needs to be changed.