Page MenuHomeLubuntu

Our default LibreOffice theme looks bad
Closed, ResolvedPublic

Description

It looks bad, yo.

Event Timeline

tsimonq2 created this task.Oct 6 2018, 7:58 PM
tsimonq2 triaged this task as High priority.

I installed these two packages and the default changed to Breeze, where Breeze is the default GTK widget style.

apt install libreoffice-gtk3 libreoffice-style-breeze

tsimonq2 claimed this task.Oct 7 2018, 5:29 PM

You're right.

tsimonq2 reopened this task as Open.Oct 9 2018, 1:46 PM

It still looks bad with those packages installed on a fresh live ISO:

hmollercl added a subscriber: hmollercl.EditedOct 9 2018, 8:34 PM

I've had problemas creating the patch.
git checkout ubuntu/cosmic doesn't work and there is also no debian changelog. Any way, the diff is this:

Description: Set default libreoffice icons to breeze for lxqt
Author: Hans P. Möller <hmoller@gmail.com>
Last-Update: 2018-10-09
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
--- a/debian/vcl/source/app/IconThemeSelector.cxx
+++ b/debian/vcl/source/app/IconThemeSelector.cxx
@@ -57,7 +57,8 @@ IconThemeSelector::GetIconThemeForDeskto
     (void)desktopEnvironment;
 #else
     if ( desktopEnvironment.equalsIgnoreAsciiCase("kde4") ||
-         desktopEnvironment.equalsIgnoreAsciiCase("kde5") ) {
+         desktopEnvironment.equalsIgnoreAsciiCase("kde5") ||
+         desktopEnvironment.equalsIgnoreAsciiCase("lxqt") ) {
         r = "breeze";
     } else
     if ( desktopEnvironment.equalsIgnoreAsciiCase("macosx") ) {
wxl added a comment.Oct 10 2018, 12:12 AM

@hmollercl are you sure that's sufficient?

wxl added a comment.Oct 10 2018, 12:15 AM

Nevermind. Looking at the example you gave that GNOME used, I think it's clear it's sufficient because the rest of the patch is a test.

hmollercl added a comment.EditedOct 10 2018, 12:46 AM

so, what should I do now? Trying to test build gave me:

hmoller@hmoller-pc:~/LOPatch/debian$ debuild -d --no-sign
debuild: found debian/changelog for package libreoffice in the directory
  /home/hmoller/LOPatch
but this directory name does not match the package name according to the
regex  PACKAGE(-.+)?.

To run debuild on this package, see the --check-dirname-level and
--check-dirname-regex options; run debuild --help for more info.
wxl added a comment.Oct 10 2018, 12:57 AM

Nothing. Building as we speak.

Trying to test build gave me:

hmoller@hmoller-pc:~/LOPatch/debian$ debuild -d --no-sign
debuild: found debian/changelog for package libreoffice in the directory
  /home/hmoller/LOPatch
but this directory name does not match the package name according to the
regex  PACKAGE(-.+)?.

To run debuild on this package, see the --check-dirname-level and
--check-dirname-regex options; run debuild --help for more info.
wxl added a comment.Oct 10 2018, 1:05 AM

Yeah well I just got that far, too, and it's all sorts of screwed up. I'm just going to go ahead and submit it. BTW, I put your name on it.

I'm doing some lobbying to get this in last minute but it also needs to be tested to make sure we're not barking up the wrong tree here.

Something just doesn't seem right here, and it reminds me of the XDG fun we had to go through with SDDM.

I just did chat with oSoMoN on IRC, and this is nowhere near what we actually need to get this working.

He's (understandably) not comfortable patching in our packaging and would rather see some upstream review and acceptance before pulling it in as a distro patch.

We could squeeze it in last minute, but that all depends on LibreOffice upstream. There's no guarantees here.

I'll grab this one for the sake of "I'm knees deep in it thus far", heh.

wxl added a comment.Oct 10 2018, 9:58 AM

To be clear, the problem is that the patch would work, but the upstream code doesn't allow LXQt as a valid value for desktopEnvironment. The appropriate places to fix are denoted by oSoMoN.

Sure.

I'll take care of it.

Submitted upstream.

Let's hope for a prompt review. If not, we can either SRU or just wait for next cycle.

There is a comment upstream saying that it won't work "because the value of $DESKTOP_SESSION is "Lubuntu", not "lxqt"." I think they are thinking in 18.04.

$ echo $DESKTOP_SESSION
Lubuntu

No, unfortunately they are correct.

After talking with oSoMoN, the only thing we can do at this point is prepare a 0-day SRU.

Can someone please file a Launchpad bug and fill it out with the SRU template?

wxl added a comment.Oct 11 2018, 2:45 PM

On the other hand $XDG_CURRENT_DESKTOP is LXQt. I'm not sure why they're looking to $DESKTOP_SESSION instead.

wxl added a comment.Oct 11 2018, 4:29 PM

Given the above, @tsimonq2 I don't think any one of us can fill out the SRU template. We need more clarity on what exactly needs to be changed.

wxl raised the priority of this task from High to Unbreak Now!.Oct 25 2018, 5:00 PM

Apparently the SRU exists.

However, the fix is FTBFS. Someone needs to talk to oSoMoN.

After doing some wabbit hunting, look what I found. And furthermore, doko uploaded a fix to Cosmic.

I'll proceed with the cherry-picking.

Ali added a subscriber: Ali.EditedNov 4 2018, 4:08 AM

I don't know whether this helps or not. I installed lxappearance to configure font and font size for gtk apps (in my case: Ubuntu regular 11). Also I created ~/.Xresources with following lines to enable slight hinting in gtk apps

Xft.antialias: 1
Xft.hinting: 1
Xft.hintstyle: hintslight
Xft.rgba: rgb
Xft.lcdfilter: lcddefault

Whilst breeze-gtk-theme can be used to have breeze theme for gtk2 apps, it doesn't work for gtk3. Hence, I installed Adwaita-qt and selected Adwaita for qt, gtk2 and gtk3 in Lxqt Appearance Configuration. This way I have a consistent look and feel for gtk and qt apps and libreoffice looks beautiful on my lovely Lubuntu 18.10

I installed lxappearance to configure font and font size for gtk app

Side note, is everything that is configurable in lxappearance also configurable in lxqt-config-appearance in terms of GTK settings? If not, what can we do about it?

The LibreOffice has migrated to Disco and will be in cosmic-proposed today for testing.

I'm curious about the test case. If I already changed the icons to Breeze, would the defaukt (Automatic in dropbox) change?

Yeah, you'll notice a definite difference regardless. Take a look at Disco.

upgraded, beside that now the dropbox says ayomatic(breeze) instead of automatic(tango) it looks the same to me since I was already using breeze icons. But nice!!

Ali added a comment.Nov 9 2018, 11:27 PM

Side note, is everything that is configurable in lxappearance also configurable in lxqt-config-appearance in terms of GTK settings? If not, what can we do about it?

Font attributes of gtk apps are not configurable in lxqt-config-appearance. You need either graphical tools like lxappearance or gtkrc files in order to change these settings. If you take a look at firefox or libreoffice, you will notice that default font is sans 10 while ubuntu 11 is the default font in lxqt-config-appearance.
I suggest to add lxappearance to Disco Dingo so that newbies can configure the look and feel of gtk apps graphically. That's what fedora does in it's Lxqt spin.
for further reading:
https://wiki.archlinux.org/index.php/Uniform_look_for_Qt_and_GTK_applications
https://wiki.archlinux.org/index.php/GTK+

Now after the sru libreoffice-gtk3 is no longer needed, libreoffice-kde5 works.

wxl added a comment.Sun, Nov 18, 10:21 PM

I have finally bothered to confirm the fix in Cosmic. @tsimonq2 can you get the SRU finished and the fix moved out of proposed?

That can only be done by modifying the bug tags as mentioned on the report.

wxl closed this task as Resolved.Tue, Nov 20, 1:56 PM

This is in cosmic-updates, so calling it done.

could we delete libreoffice-gtk3 in cosmic update? leaving libreoffice-kde5 alone