Don't SRU. Let's close it.

So here's what we should probably have as required information for testing results:

1. from lspci -nnk
   1. PCI ID of graphics card
   2. name of graphics card
   3. kernel module being used
2. with ps -o rss -C compton | numfmt --header --field=1 --to=iec --padding=5, run under the same conditions and after the same amount of time elapsed since starting compton
   1. with old compton
   2. with new (PPA) compton
3. The tests should be run under the following conditions
   1. with several windows open
   2. the same configuration, preferably with lots of opacity and transparency and shadows
4. additional checks
   1. try youtube videos in full screen
   2. anything else graphic intensive: games, etc.

Fix changelog.

I'm playing with wxl/testy compton, and noted a

It definitely wasn't doing anything until I applied the preferences file (without any changes):

As long as the new file is installed, this is fine

Thanks for working so hard on this.

@The_LoudSpeaker did you see all the suggestions I made (across several packages) at T21#594? Looks like latest in Debian doesn't have any of the new hacks, so don't sweat looking beyond that.

ps aux might be more helpful.

Closed per @hmollercl.

You can always close it then @hmollercl but I'll do it for you :)

I don't know if compton was really running.
There was nothing output to the console.
When I edited the compton preferences and restarted compton, the console printed:
$ compton
[ 08/21/19 01:40:20.668 parse_config_libconfig WARN ] Option no-dock-shadow is deprecated, and will be removed. Please use the wintype option shadow of dock instead.
[ 08/21/19 01:40:20.668 parse_config_libconfig WARN ] Option no-dnd-shadow is deprecated, and will be removed. Please use the wintype option shadow of dnd instead.
[ 08/21/19 01:40:20.668 parse_config_libconfig WARN ] Option menu-opacity is deprecated, and will be removed.Please use the wintype option opacity of popup_menu and dropdown_menu instead.
[ 08/21/19 01:40:20.668 parse_config_libconfig WARN ] vsync option will take a boolean from now on. "none" is interpreted as "false" for compatibility, but this will stop working soon
[ 08/21/19 01:40:20.669 parse_config_libconfig WARN ] glx-swap-method has been deprecated since v6, your setting "undefined" should be removed.
[ 08/21/19 01:40:20.669 parse_config_libconfig WARN ] "clear-shadow" is removed as an option, and is always enabled now. Consider removing it from your config file
[ 08/21/19 01:40:20.669 parse_config_libconfig WARN ] "paint-on-overlay" has been removed as an option, and is enabled whenever possible
[ 08/21/19 01:40:20.669 parse_config_libconfig WARN ] "alpha-step" has been removed, compton now tries to make use of all alpha values

This can be considered "closed"

Where you able to convert my notes back to text or are they corrupted?

I had a good test on my Acer Laptop. Laptop is somewhat low on resources. 1st gen i5 with 4G of RAM that is shared with the onboard Intel graphics. As far as resource usage it was almost identical with the original compton. 457 M for the original and 460 M for the new one. I had around 430 M with no compton installed. I used htop for all three measurements. I notice a bit of stuttering with both versions when moving windows around. I also tested the compton-conf that is shipped in Lubuntu and that seems to manage the config file fine. I see no downside currently.

Check D18. Included this.

I made a list of those which are good from the currently shipped ones:
abstractile
binary ring
cwaves
Deco
Fiberlamp
fuzzy flakes
penrose
popsquares
slidescreen

Also can't make any sense out of your notes.

@bjlockie thanks, though one thing that would be nice is a comparison to the old compton. Does one use more or less resources?

grrr, I made all my notes in a leafpad text file and they were corrupted when I saved them.
I probably should have updated my system.

My testing steps:

In case it wasn't obvious, I believe I have a solution that will make the lxqt-globalkeys patches work. If people could use the above PPA to test (see here for a testcase), that would be great. This is very important because if we don't have some sort of solution here, we won't be able to include our own Lubuntu-specific changes to the lxqt-globalkeys config, which means we won't really be able to do anything with the shortcuts. Raman's put a lot of hard work here that I would not like to see go to waste, nor would I like to make some rash decisions before release to deal with the fact that the Super key conflicts. So please go test!!!

@hmollercl Made comment to drop the desktop. It's from upstream.

so far examined on

Thanks to @teward I could fix the override of lintian for binary. In /debian created a file called <package>.linitian-overrides

I've looked for bugs as far as upstream related to NotShowIn and I can't find anything. I've pinged #ubuntu-flavors to see if they have problems as well.

Strangely xdg-desktop-menu forceupdate isn't really behaving nice, but a log out and back in does the trick. I can change various attributes but that indeed seems to have no effect.

It does it on a live iso, I wouldn't think there was any cache.
I also did try this on a different .desktop file and I tried a logout and login as well as a reboot. They all still show.

How are you ensuring the menu's cache is being updated?

In T108#2111, @wxl wrote:

No, that's not it. $XDG_CURRENT_DESKTOP is LXQt as it should be.

No, that's not it. $XDG_CURRENT_DESKTOP is LXQt as it should be.

I don't know this one off the top of my head, but you should see what environment variable the menu reads from to determine whether or not to show menu items. Probably in lxqt-panel.

@wxl I am confused here. I added NotShowIn=LXQt; to the desktop file yet it still shows in the menu. I re-read the spec and still don't see where I went wrong. Any ideas?

lxqt-archiver still FTBFS. On the other hand, Arqiver works great. Maybe we should switch our attention and see how it goes? It's now officially added to the libfm-qt archivers list.

Bounced. Keep an eye on it.

We should bounce this to 20.04 IMHO. There are some issues still upstream, this one impacts us. Then there is this, this and this.
To top it off, I can't see where you can remove packages, only add them, we'd have to tinker on that too. As much as I would like to see it, I don't think it is ready for us at this time.

@kc2bez what's the word here?

No movement on this, so I'm kicking it.

This is a good idea, but it's not something we can adequately control yet. All settings are specific to a particular device. There's no way to refer to pointing devices in general. There is some discussion about ways to implement this but it's uncertain.

So I took the packaging for the current compton and tweaked it for the new one. I was freaked they use meson to build but it seems dh is all good with that. They do have a test.h submodule that's part of the build process that is going to included in the next release, due no later than next week. It was serendipity that while trying to figure that out, I noticed that in that same issue, someone had mentioned all the Ubuntu depends. So I trashed the old ones and used the new ones. I also dropped all the old patches. The only patch is the one for test.h.

So the patch needed a little hand nudging. Not much. Someone please test and double test the version of lxqt-globalkeys I have in this PPA.