Modified Diff

So this goes as a SRU?

Undo the modifications to workaround-missed-file-monitoring.patch
updated timestamp using dch -r

Removed libfm-qt6/ and libfm-qt-l10n/
edited header
using P31

D32 is the diff you should be looking at.
And here's the longest paste ever: P30
Includes build log. Had to build more than once. Don't remember exactly how many times.

As I said that day, there are several commits after latest release. total 7 affecting the concerned file. But among those commits, other files are also changed. So I will have to try to create a patch of each concerning commit and then merge all patches into one. *Then* try to apply that patch. A bit busy today. Have a marathon tommorow. Will give it a shot on friday.

That seems fair. Okay. So we do not change the grub config file.
To include the theme in live usb where do we put it?

In the /etc/default/grub,
GRUB_TIMEOUT_STYLE is set to 'hidden' by default for new installations if only lubuntu is installed and not dual booted.
This makes grub to not show up in single installation systems. Thus, not showing the theme. It should be changed to menu or be unset. I don't know which task this comes under. Maybe cala settings? @wxl @kc2bez @hmollercl any inputs?

@guiverc thanks for testing.
About not finding package, I am not sure I understand what happened. But I just upgraded a vm from 19.04 to 19.10 and Installed the ppa and was able to use sudo apt install lubuntu-grub-theme.
Maybe you tried adding the ppa to a 19.04 system.
In dch. I have set eoan.

Test it ploxx.

There are 7 commits in all, affecting the concerned file. Some of them are highlighted in the image below

The patch doesn't apply. There are waaay too many changes since last release. around 60 something commits.

I have asked about new release here
https://github.com/lxqt/lxqt-globalkeys/issues/130

Right now I am on branch arcpatch-D17_1. Should I be on ubuntu/eoan ? something I missed?

So do we just remove the line BROWSER=firefox from this file ?

In T59#1777, @wxl wrote:

What about applying the patch to the latest *release* on GitHub?

In T59#1521, @wxl wrote:

I didn't. I was asking if it did. Can you take the most recent upstream release (from GitHub) and patch it and build it?

soooo, as far as I understand, we need this commit as a patch for the latest upstream release.

updated version no and changelog

Minor changes

The patch was merged. The patch wasn't applied initially to master branch coz it is a part of PR#60 and now it was merged 19hrs ago. Ref:
https://github.com/lxqt/lxqt-globalkeys/pull/123#issuecomment-515904488
I will try building it from latest code on master branch.

@tsimonq2 I will have a look into it as soon as I am done with T59. Sorry for the delay.

@wxl Please Check

added a changelog entry

Modified Shortcuts
Shortcuts for following are modified:

• Go to Desktop
• Send to Desktop
• Directional Cycle Windows
• Go to Desktop Directional
• XF86WWW

Shortcuts for following are removed

• Toggle show desktop
• PCmanfm
• Runner
• Terminal
• Task Manager

Some commented out items are removed

• Lxpanel Meni
• Lxsession default lock
• Calculator
• Screenshot
• Quit

Following shortcuts are completely removed

• CTrl+f10/f11 regarding backlight
• Ctrl+f7 xset dpms force off

@tsimonq2 Yup! I will have a look.

I took the most recent code. Checked out to the xdg-config branch. Then built it using normal instructions. It did build and also got installed locally and that was how I tested it. I will try tomorrow without checking out to that branch. Will get back once done.

Can you list steps you followed?

The build failed. I pasted the log into P19. The makefiles that might be causing the issue must be P20 and P21. (They are refrenced in lines 427 and 425 of P19 resp.)

Hey! @wxl I tested this pull request It works fine. Even the Super+Fx key bindings work fine as they should. I will now try packaging it. The only problem is, the patch is not on master branch, its on xdg-config branch. So after downloading source, I will just checkout that branch and then build it. hopefully it will work.

We should add a script at the end of installation, after it sets bootentries and makes directories under ESP, which will set

GRUB_DISTRIBUTOR=lsb_release -i -s 2> /dev/null || echo Debian

but the problem we will have, as @apt-ghetto said in the task description, is that lubuntu-grub-theme will not use the hummingbird logo, I will lookup what can I do about that.

@guiverc Thanks!
@wxl Imo this is the best we have, in terms of resolution.
I can add fonts if you want me to.

@kc2bez Thanks!
About desktopswitch2, for me, if I change desktopswitch in P9 with desktopswitch2, the super+Fx keys retain themselves, they do not revert to Ctrl+Fx

Job is not done yet, not untill D18 gets sorted.

Removed "Lubuntu Specific Key bindings"

So..? We wait then?

Removed media keys

Hey @wxl I commented out the media keys from lxqt-rc.conf and added them to globalkeyshortcuts.conf. Those which were transfered were Mycomputer and Calculator. I couldn't add the Terminal key. I tried setting it to something else and then change it by editing the file but no. that entry disappeared after a reboot.
Also, added a couple of new media keys, (got hands on an extra keyboard for sometime):

@guiverc Thanks! The d755 with 16:10 display looks decent. But there isn't much change on d780 with 4:3 displays. But it's okay. Nothing much I can do.

Yup! Thanks @guiverc

I was going to suggest this. I need this very much. Always have to log in using firefox for no reason.

Yup! I have been noticing it since day 1. That's why I wanted to see how it looks on actual hardware in bios. What's the default resolution on actual hardware in bios?
Idk why the icon is looking pixelated, I have used the one with maximum pixel size 512x512. If smaller are used, they do not look as much detailed in larger screens.
About top logo being scrunched, it is because, it's a part of the background. There is nothing like "Title-logo" which could point to the logo file. So I had to paste it over earlier background.

updated the patch description

Added link to the bug in patch description

@guiverc The viao showing up 19.04 is mostly because you must have updated from 19.04 to 19.10. same is the case with me.

Removed debian/lxqt-globalkeys-l10n

Updated the theme, everyone who's testing please check.

How does this look:

@hmollercl
The window tilling shortcuts are removed.
Yup! the 'Ctrl+Alt+arrows' switch desktops. Like they switch to the next desktop in that direction.
'Ctrl+Fx' is not set for anything. I think you mean 'Super+Fx' ? That switches to the desktop numbered 'x'

Done. Check D17 and D18.

Edited shortcuts.
Patched rLXQTGLOBALKEYSPACKAGING. See D18.

Yeah. But I don't know how to go about it. Never patched a repo which is already patched. Please give instructions on the channel. :)

Yeah nothing has Super key in openbox.

I just checked, The lubuntu-default-settings package doesn't have globalkeyshortcuts.conf in the in the src. I mean it's not in this folder:
https://phab.lubuntu.me/source/lubuntu-default-settings/browse/ubuntu%252Feoan/src/etc/xdg/xdg-Lubuntu/lxqt/

For openbox and for lxqt, I am assuming that both the local config files are generated from the ones kept at /etc/xdg/openbox/lxqt-rc.xml and /etc/xdg/lxqt/globalkeyshortcuts.conf (Tell me if I am wrong.)

GoToDesktop = C + A + $direction cannot be added to lxqt-global config. It works from openbox conf.
Reason:
Apparently, 'panel/desktopswitch/left' or 'panel/desktopswitch/next' doesn't work as a command.

Hey! checkout these files.
Replace the following files with respective files from attached archive:

1. .config/openbox/lxqt-rc.xml
2. .config/lxqt/globalkeyshortcuts.conf

Single Installations from 19.04 on wards definitely make entry as "lubuntu". Does 18.04 makes entry as "ubuntu" @wxl ?

*Heavenly fire!!

Hmmm. 🤔 I don't know why grub is creating the entry named "Ubuntu" for you when you have lubuntu installed.

@guiverc whenever you are free and have a single lubuntu Installed bios system, check for the logo, it should be there.

I think Ctrl+Alt+Tab aims to cycle between windows on all desktops. simillar to ubuntu's same shortcut as mentioned on this page But sigh! both lubuntu and ubuntu fail to achieve this. even in ubuntu 19.04 Ctrl+Alt+Tab switches between Topbar and windows.

@wxl he doesn't see it coz I have added icon only for lubuntu and not for ubuntu. His entry is named as "Ubuntu" not "Lubuntu" as compared to your and my case. Should I add an icon for ubuntu also?

Noice. Timeout bar working fine in each case? I think on screens with 3:4 ratio, it might be overlapping the central list. It kinda just remained at the bottom edge for me in a vm. here's the image

Thanks @guiverc ! Can you share the information about resolution of the hp dx6120 screen?

Btw, what is this useful for? It focuses between panel and pcmanfm-qt. More like between panel and desktop manager I guess.. Check the attached link to see it in action.

<keybind key="C-A-Tab">
    <action name="NextWindow">
      <panels>yes</panels><desktop>yes</desktop>
      <finalactions>
        <action name="Focus"/>
        <action name="Raise"/>
        <action name="Unshade"/>
      </finalactions>
    </action>
  </keybind>

Link(Ctrl+Alt+Tab)

Here is the link to git.

Hey! I have a first draft of the theme ready. Where should I upload it? So that you guys can also test it?

In T30#1180, @wxl wrote:

Looks like MATE no longer installs the theme by default because it's problematic with some hardware it seems. Curious.

Whoops! My bad I thought you had claimed this task @wxl Sorry for the message on telegram. I had recieved the email notif and I was in a hurry so didn't read properly. My bad. Really sorry. I will complete the task asap. Really sorry again!

In T21#608, @wxl wrote:

The app-defaults file will usually be  named  /usr/lib/X11/app-defaults/XScreenSaver,

Removed ubuntu-report as it was not required according to T50

So. how do we go about removing ubuntu-report? Which repo should I clone?

As @apt-ghetto suggested in T2, following worked for me.

In T2#552, @apt-ghetto wrote:

I have tested this on a virtual machine (VMWare Workstation 14 Player with EFI).
Before installing:

wget http://launchpadlibrarian.net/418441015/libkpmcore7_3.3.0-5_amd64.deb
sudo apt install ./libkpmcore7_3.3.0-5_amd64.deb

During the installation I choose to erase the disk and selected the checkbox to encrypt the disk.
After installation and reboot, it works as just fine.
Where exactly is the magic, that it works now?

Some were recovered from google cache right?@tsimonq2

Any sugestions as to which themes we should use? And how do I go about working on this?